[GitHub] [zeppelin] jongyoul merged pull request #4601: [ZEPPELIN-5910] Remove hamcrest-all as compile dependency

jongyoul merged PR #4601: URL: https://github.com/apache/zeppelin/pull/4601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[GitHub] [zeppelin] jongyoul commented on pull request #4601: [ZEPPELIN-5910] Remove hamcrest-all as compile dependency

jongyoul commented on PR #4601: URL: https://github.com/apache/zeppelin/pull/4601#issuecomment-1546544979 I approved it. BTW, you can feel free to ping me or assign me as a reviewer to send me a notification :-) I'm willing to help to review if needed. -- This is an automated message from

[GitHub] [zeppelin] Reamer commented on pull request #4601: [ZEPPELIN-5910] Remove hamcrest-all as compile dependency

Reamer commented on PR #4601: URL: https://github.com/apache/zeppelin/pull/4601#issuecomment-1545796787 I need a review here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] Reamer merged pull request #4597: [ZEPPELIN-5908]JDBCSecurityImpl should relogin when authType='kerberos' to void kerberos ticket expired

Reamer merged PR #4597: URL: https://github.com/apache/zeppelin/pull/4597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apach

[GitHub] [zeppelin] zhugezifang commented on pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

zhugezifang commented on PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1545545539 > I found two minor improvements. Can you correct your formatter. For example, Zeppelin uses an indentation of two spaces. Furthermore, the use of antlr4 must be included in the [li

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

Reamer commented on code in PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1192064601 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/antlr/SqlSplitVisitor.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

Reamer commented on code in PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1192046617 ## zeppelin-interpreter/src/main/java/org/apache/zeppelin/antlr/SqlSplitVisitor.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] zhugezifang commented on pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

zhugezifang commented on PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1545324330 > > We need also an integration in the new UI `zeppelin-web-angular`. > > hi @Reamer i am not familiar with the new ui of angular , is there a developer familiar with angular i