[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1210 @volumeint cool! Do you mind make a pullrequest with modification `test: /\.png(\?\S*)?$/, loader: 'url-loader'` ? --- If your project is set up for it, you can reply to this emai

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2299 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2307: [HOTFIX]. Minor doc fix for back-end-angular.md

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2307 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2293: [ZEPPELIN-2461] Masking Jetty Server version with User...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2293 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2305: [ZEPPELIN-2382] Fixed windows compatibility of interpr...

2017-05-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2305 @cfries yes, close and re-open will trigger Jenkins and get latest travis job result. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2303: add basic .appveyor.yml

2017-04-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2303 Created issue http://issues.apache.org/jira/browse/ZEPPELIN-2478 for follow up. I'd like to merge to master if no further discussions, while missing .appveyor.yml mark all PR

[GitHub] zeppelin pull request #2303: add basic .appveyor.yml

2017-04-30 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2303 add basic .appveyor.yml ### What is this PR for? After appveyor ci is enabled for windows, PR build status shows red cross because of missing .appveyor. This PR add skeleton

[GitHub] zeppelin issue #2262: [HOTFIX] Fix CI build failure on branch-0.6

2017-04-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2262 Merged to branch-0.6. But somehow @asfgit does not close it automatically. @hammertank please close this PR manually. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2264: [ZEPPELIN-1711] Create `Dockerfile`s for released bin

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2264 @1ambda great work! LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2221: [ZEPPELIN-2216] general solution to precode. refactori...

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2221 LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2281: added principalSuffix to AD examples

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2281 Thanks @paul-brenner for the contribution! LGTM and merge to master and branch-0.7 if no further discussions --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1574 Great work. Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2262: [HOTFIX] Fix CI build failure on branch-0.6

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2262 LGTM and merge to branch-0.6 if no further comment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2286: Jenkins CI test

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2286 PR builder triggered and run normally. But somehow github page does not display build state. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2289: [ZEPPELIN-2452] Can not handle message in revision mod...

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2289 Could you make CI green https://travis-ci.org/cloverhearts/zeppelin/builds/225928425? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2288: [ZEPPELIN-2452] block update paragraph event on revisi...

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2288 Could you make CI build success? https://travis-ci.org/cloverhearts/zeppelin/builds/225916461 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2265 This PR has been opened for last week. LGTM and Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2290: [ZEPPELIN-2448] Fix paragraph navigation issue

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2290 Tested and LGTM Merge to master and branch-0.7 if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2275: [ZEPPELIN-2442] button to create note into folder (nav...

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2275 LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2292: [HOTFIX] Removed adduser while creating note

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2292 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2286: Jenkins CI test

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2286 I have no good idea. https://issues.apache.org/jira/browse/INFRA-14005. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2287: SSL Support for Groovy Interpreter HTTP requests [ZEPP...

2017-04-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2287 CI build https://travis-ci.org/dlukyanov/zeppelin/builds/225949679 LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin pull request #2286: Jenkins CI test

2017-04-25 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2286 Jenkins CI test will not be merged. for test purpose. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin ci_test

[GitHub] zeppelin issue #2278: [ZEPPELIN-2431] Corrected deletion of notes by incorre...

2017-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2278 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2279: [HOTFIX] Add livy build in .travis

2017-04-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2279 Isn't `# Test interpreter modules` and `# Test spark module for 2.1.0 with scala 2.11, livy` test livy? --- If your project is set up for it, you can

[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...

2017-04-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2270 Tested. Works really nicely! really cool! LGTM and merge to master if no further discussions! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2271: [ZEPPELIN-2414] Memory leak under scoped mode of Spark...

2017-04-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2271 Thanks @hammertank for the contribution. What do you think wrap interpreter using [ClassLoaderInterpreter](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main

[GitHub] zeppelin issue #2262: [HOTFIX] Fix CI build failure on branch-0.6

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2262 Thanks @hammertank for the contribution. I can see commits included in this PR came from other branch. In this case we'd like to cherry-pick and preserve original author to

[GitHub] zeppelin issue #2238: 0.7.1 with ssl

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2238 Thanks @alourie for the contribution Could you configure CI? Following message from Jekins might help. ``` Looks like travis-ci is not configured for your fork. Please setup

[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2270 @1ambda Can this be applied to table visualization, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2265 Tested and it works well! Although i really really like this improvement because it allow utilize small screen more efficiently, i'd like to open this PR for next few more days

[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2235 CI build passed. https://travis-ci.org/cfries/zeppelin/builds/224499519 Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2276: [ZEPPELIN-2410]: Using UUID from filename in registry ...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2276 Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2273: [ZEPPELIN-2439] Use babel-preset-env to specify browse...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2273 LGTM. Merge to master if no further comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2269: [ZEPPELIN-2434] Credential feature does work in JDBC i...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2269 Merge to master and branch-0.7 if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2276: [ZEPPELIN-2410]: Using UUID from filename in registry ...

2017-04-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2276 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...

2017-04-20 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/2269 [ZEPPELIN-2434] Credential feature does work in JDBC interpreter ### What is this PR for? Credential feature does not work in JDBC interpreter. This PR fixes unittest that does

[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...

2017-04-20 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/2269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2269: [ZEPPELIN-2434] Credential feature does work in...

2017-04-20 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2269 [ZEPPELIN-2434] Credential feature does work in JDBC interpreter ### What is this PR for? Credential feature does not work in JDBC interpreter. This PR fixes unittest that does

[GitHub] zeppelin issue #2267: [MINOR] Verbose logging in zeppelin-web

2017-04-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2267 LGTM and merge to master if no further comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2263: ZEPPELIN-2421. AngularObject miss AngularObjectListene...

2017-04-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2263 Thanks @zjffdu for the fix. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...

2017-04-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2260 LGTM and merge to master and branch-0.7 if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2234 LGTM and merge to master if no further discussions! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2261: [ZEPPELIN-2420] Slow notebook listing in navbar

2017-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2261 Merge to master and branch-0.7 if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree

2017-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2234 Let me take a look and come back --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2233: [MINOR] Add paragraph to note

2017-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2233 LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2259: Prevent NPE on delete local module cache

2017-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2259 Thanks @1ambda for review. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...

2017-04-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 Thanks @soralee. merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2259: Prevent NPE on delete local module cache

2017-04-18 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2259 Prevent NPE on delete local module cache ### What is this PR for? Prevent NPE on delete local module cache in HeliumBundleFactory ``` Caused by: java.lang.NullPointerException

[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...

2017-04-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 Ah, just one more thing. @soralee could you make CI green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...

2017-04-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 Great improvement @soralee. Tested and LGTM. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...

2017-04-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2235 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...

2017-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2248 LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2251 Thanks @tinkoff-dwh for useful feature! Tested this PR. In interpreter setting page, I can change type of property. ![interpreter_property_type](https

[GitHub] zeppelin issue #2203: [ZEPPELIN-2297] improvements to jdbc autocompleter

2017-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2203 merge to master if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2240: ZEPPELIN-2386. Add parameter for check running current...

2017-04-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2240 Thanks for explain. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2245: ZEPPELIN-2395. Refactor Input.java to make dynamic for...

2017-04-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2245 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2249: ZEPPELIN-2356. Improvement for z.angularBind and z.ang...

2017-04-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2249 @zjffdu do you mind update corresponding docs, too? `docs/displaysystem/back-end-angular.md` And front-end expose angular display system apis. Do you think this guy need to

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

2017-04-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2098 Tremendous work @1ambda ! LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...

2017-04-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 Tried last commit and it looks great. However, in the beginning "Default" radio button is not selected automatically. ![image](https://cloud.githubusercontent.com/asse

[GitHub] zeppelin issue #2240: ZEPPELIN-2386. Add parameter for check running current...

2017-04-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2240 @zjffdu In ZeppelinIT.testAngularDisplay, 4th paragraph creates watcher and watcher call `z.run()` without passing interpreter context. like ```scala z.angularWatch

[GitHub] zeppelin issue #2221: [ZEPPELIN-2216] general solution to precode. refactori...

2017-04-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2221 Let me take a look in this weekend! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder

2017-04-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2228 Thanks for the new feature. LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2241: ZEPPELIN-2390. Improve returnType for z.checkbox

2017-04-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2241 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2196: fix bugs for timer saver

2017-04-08 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2196 @wary Thanks for the contribution! LGTM and merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-04-08 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2227 \cc @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-04-08 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2227 Usage of existing display systems is `%DISPLAY_SYSTEM_NAME` (e.g. `%table`, `%html`). Will where be a way to keep usage the same whether display system is installed by Spell or not? --- If

[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group

2017-04-08 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2225 Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2231: ZEPPELIN-2150. NoSuchMethodError: org.apache.spark.ui....

2017-04-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2231 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one

2017-04-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2210 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group

2017-04-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2225 I was very annoying problem. Thanks @1ambda for the fix. Tested and LGTM. Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2215: [ZEPPELIN-2341] Remove -Psparkr build profile

2017-04-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2215 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one

2017-04-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2210 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2151 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2158: [ZEPPELIN-2279] excluded comments from SQL

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2158 Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 LGTM and merge to master if no further discussions. Thanks @tinkoff-dwh for the improvement! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2219: [ZEPPELIN-2348] Line chart setting is not rendered (br...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2219 @1ambda This PR has merged but @asfgit didn't close it. Could you close it manually? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] zeppelin issue #2219: [ZEPPELIN-2348] Line chart setting is not rendered (br...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2219 Merge this to branch-0.7 along with #2218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2216 Merge to master and branch-0.7 as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2218: [ZEPPELIN-2348] Line chart setting is not rendered (ma...

2017-04-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2218 While this fixes broken feature, i'm merging it to master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2216 LGTM I think ZEPPELIN-2336 is quite serious issue. Once CI becomes, let's merge this PR asap to master and branch-0.7 as a hotfix, and reopen ZEPPELIN-1145 for fu

[GitHub] zeppelin issue #2218: [ZEPPELIN-2348] Line chart setting is not rendered (ma...

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2218 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2213 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' next to ...

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2211 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2210 Great work. Tested but I'm getting error on enabling package. ![image](https://cloud.githubusercontent.com/assets/1540981/24630417/9bb7ed52-18f7-11e7-8d5c-df137c12146

[GitHub] zeppelin issue #2214: [MINOR] remove typo in line and area chart

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2214 LGTM and merge to master and branch-0.7! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2120: [ZEPPELIN-1492] fixing the issue where updating a para...

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2120 @FRosner Thanks for the fix. LGTM and merge to master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2213 [this section](https://github.com/apache/zeppelin/blob/master/docs/install/virtual_machine.md#how-to-build--run-zeppelin) need to be updated, too. --- If your project is set up for it, you

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2216 @khalidhuseynov last commit in the master branch does not have test failure on second profile. Could you rebase and see if second profile passes? Also this PR restores changes made in

[GitHub] zeppelin issue #2158: [ZEPPELIN-2279] excluded comments from SQL

2017-04-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2158 LGTM \cc @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2203: [ZEPPELIN-2297] improvements to jdbc autocompleter

2017-03-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2203 Great improvement! LGTM \cc @cloverhearts @astroshim --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2209: [DOC] 0.7.1 release note

2017-03-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2209 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

2017-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Great work!!! Looks great to me! I think it's worth to move usages and examples in this PR description under `/docs`. Where do you think this information c

[GitHub] zeppelin issue #2133: [ZEPPELIN-1357][Umbrella] Text overlap in the MultiBar...

2017-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2133 I tested a bit more and found some cases. 1. Label rotated when unnecessary ![image](https://cloud.githubusercontent.com/assets/1540981/24431884/7500d71a-13d3-11e7-9a0e

[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]

2017-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2135 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2113: [ZEPPELIN-2190] Support custom web development port

2017-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2113 LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2178: [ZEPPELIN-2302] Add info level logs when installing no...

2017-03-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2178 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]

2017-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2135 Thanks @dlukyanov for the contribution. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2188: [MINOR] Job parameters synchronization

2017-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2188 Merged to master, but didn't merged to branch-0.7 because of conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing

2017-03-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2192 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

<    1   2   3   4   5   6   7   8   9   10   >