Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2163
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@dlukyanov Thanks for the update and explanation on behavior.
Inside of docs directory, groovy.md will need some header to be compiled
with Jekyll. For example,
[spark.md](https
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2188
Merge to master and branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2188
Thanks for the contribution!
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2183
Just merged to branch 0.7. but @asfgit did not automatically closed this
PR. @andreaTP could you close this PR manually?
---
If your project is set up for it, you can reply to this email and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@tinkoff-dwh Ah, i see. i didn't see where this margin comes from.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@tinkoff-dwh thanks!
It's nit, but bottom margin is bit much compare to other margins in
paragraph. i tried mark other margins.
Top margin looks bit small and bottom margin looks too large. What do you
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
I tested last commit and it works well.
However the variable can't be read from the other paragraph.
.
Do you have idea why it was failed when `waitForParagraph(1, "FINISHED")`
replaced sleep?
---
If your project is set up for i
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2173
LGTM and merge to master and branch-0.7 if no further comments.
Thanks @elkangaroo for the contribution!
---
If your project is set up for it, you can reply to this email and have your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2185
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2184
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2158
LGTM
Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2167
Thanks @Remilito for working on this issue.
Merge to master and branch-0.7 if no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2168
Thanks for working on the issue.
I have tested problem
[ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889) in current
master. However i couldn't reproduce the pr
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Thanks @andreaTP for the improvement!
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2170
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2172
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Looks like second test matrix succeeded after the manual restart.
In this case, you also need to trigger Jenkins again to check latest build
status.
Simply close and reopen this PR will
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2173
Looks like travis changed the name of option from "build pushes" to "Build
branch updates".
Amend your last commit with `git commit --amend` and do `git push
your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2158
I fixed Jenkins build command the problem taking wrong commit hash when
it's got merge commit.
Now Jenkins will take correct commits. @tinkoff-dwh Could you try close /
re-open this P
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2169
[CI-TEST] Jenkins build script test
Jenkins build script test with organization repository.
Won't be merged.
You can merge this pull request into a Git repository by running:
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2169
[CI-TEST] Jenkins build script test
Jenkins build script test with organization repository.
Won't be merged.
You can merge this pull request into a Git repository by running:
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
I made a mistake. And updated the jenkins command again. @andreaTP Could
you close/reopen once more? :-)
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2169
[CI-TEST] Jenkins build script test
Jenkins build script test with organization repository.
Won't be merged.
You can merge this pull request into a Git repository by running:
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
I updated Jenkins build command. @andreaTP can you close / reopen this PR?
Jenkins now will check https://travis-ci.org/nokia/zeppelin/builds/213131116
correctly.
---
If your project is set
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2169
[CI-TEST] Jenkins build script test
Jenkins build script test with organization repository.
Won't be merged.
You can merge this pull request into a Git repository by running:
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Looks like Jenkins build script still does not handle contribution from
organization repository very well.
Let me try fix this.
---
If your project is set up for it, you can reply to this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2167
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2158
Looks like somehow this branch includes commits not part of this
contribution.
for you fork?
And then you'll need rebase this branch to include some fixe
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2163
CI problem has fixed on master branch. Can you rebase and see if this PR
passes the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2166
Tested and it works well.
Could you setup travis-ci for your fork and see if it passes the test?
Please take a look
[CI](http://zeppelin.apache.org/contribution/contributions.html
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2162
I rebased to current master and CI becomes green!
Merge this PR to master and branch-0.7 as a hotfix while it significantly
reduce chance of failing 2nd and 3rd test matrix by timeout
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2162
@sravan-s Test failure
`NotebookTest.testAngularObjectRemovalOnInterpreterRestart:699` is already
addressed in the commit
https://github.com/apache/zeppelin/commit
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2164
Tested and LGTM.
It fixes test failure on SELENIUM test matrix.
Merge to master as an hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2162
[ZEPPELIN-2286] Some test matrix on Travis often exceeds time limits (50min)
### What is this PR for?
This PR optimize CI test matrix while keeping the same test coverage.
from
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2155
Merge to master and branch-0.7 as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2159
Tested and it works perfectly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2157
CI became green.
I'm merging it to master and branch-0.7 as a hotfix.
Created issue https://issues.apache.org/jira/browse/ZEPPELIN-2284 to make
sure remove AngularObje
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2157
[HOTFIX] Fix CI
### What is this PR for?
CI is failing since
https://github.com/apache/zeppelin/commit/970b8117a48a31a9375bf7f76142117fd9b3bd86
This PR tries to make CI green
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2157
[HOTFIX] Fix CI
### What is this PR for?
CI is failing since
https://github.com/apache/zeppelin/commit/970b8117a48a31a9375bf7f76142117fd9b3bd86
This PR tries to make CI green
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2154
The error is not related to this change. I'm working on the CI error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2156
Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2156
Yes, i think user will expect that same behavior `dropdown` and `checkbox`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2156
When "Run on selection change" is checked, check box change does not run
paragraph. @AhyoungRyu can you check?
---
If your project is set up for it, you can reply to this email and
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2155
[HOTFIX] Dynamic form in python interpreter
### What is this PR for?
https://github.com/apache/zeppelin/pull/2106 rewrote python interpreter.
But dynamic form feature is not rewritten
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2085
Thanks @tinkoff-dwh for useful new feature.
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2152
Merge to master and branch-0.7 if no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2153
[ZEPPELIN-2282] NPE on NotebookServer.java when client send null ticket.
### What is this PR for?
When client (zeppelin-web) send message with null ticket, NotebookServer
does not handle
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2143
LGTM and merge to master if no further comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2144
Cool improvement!
LGTM and merge master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Message location
Because of existing message `Results are limited by X.` and `Output
exceeds 10240. Truncated.` are displayed below the table.
I think showing `Attention
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2152
[MINOR] Display chart by default in basic tutorial notebook
### What is this PR for?
From some point, "Zeppelin Tutorial/Basic Features (Spark)" tutorial
notebook does not dis
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2131
Merge to master and branch-0.7 if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
In addition to @prabhjyotsingh mentions, there are another type of message
controlled by `ZEPPELIN_INTERPRETER_OUTPUT_LIMIT` env variable.
 to this branch, to
bringing docker support back . Please take a look and merge if you think it's
okay.
-
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2114
Merged to `branch-0.7` but @asfgit does not automatically close this PR.
@1ambda please close this PR manually.
---
If your project is set up for it, you can reply to this email and have your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2100
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2138
Merge to branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Merge to master if no further comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Thanks for pinging.
LGTM and merge to master if no further discussions.
Meanwhile, @andreaTP do you mind create a JIRA issue?
So later, everyone can more easily track when this
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2140
@jongyoul Great work.
I tested this PR and found some problem. We need some followup here.
1. Can not use interpreter after restart in `Per User scoped mode`,
After
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2106
Tested `%python.conda` and `%python.pandasql` and it works well.
Could you restore PythonDockerInterpreter.java and
PythonDockerInterpreterTest.java for `%python.docker` as well
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2114
@1ambda Thanks! LGTM and merge to branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2137
You can set `ZEPPELIN_HELIUM_REGISTRY` environment variable in
`conf/zeppelin-env.sh` or `zeppelin.helium.registry` property in
`conf/zeppelin-site.xml`.
[Default
value](https
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2100
Ah i realized that "Run on selection change" is not persisted, so
refreshing browser resets the option. @AhyoungRyu Could you take care?
---
If your project is set up for it, you ca
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Merge to master and branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2100
LGTM.
@AhyoungRyu Do you mind improve unittest to not only verify button is
checked, but also verify actual dynamic form behavior, in this PR or later in
the other PR.
---
If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Thanks @FRosner reviewing the PR.
> ``` INFO [2017-03-15 10:41:22,547] ({main} Helium.java[loadConf]:114) -
Add helium local registry /usr/local/zeppelin/helium
> INFO [2
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2099
Thanks @Remilito for the contribution!
Could you elaborate why do you support two different forms of message?
```
{
...
"graph": {
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2116
CI failure on `branch-0.7` is fixed. @1ambda Could you rebase this PR to
`branch-0.7` and see if CI passes?
---
If your project is set up for it, you can reply to this email and have your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2115
This PR has been merged but @asfgit does not close this PR automatically.
@1ambda Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2124
CI failure on `branch-0.7` has fixed by
https://github.com/apache/zeppelin/pull/2103.
@soralee could you rebase this PR to `branch-0.7` and see if CI passes?
---
If your project is set up
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2131
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
The error
```
[ERROR] error An unexpected error occurred:
"https://registry.yarnpkg.com/binary-extensions/-/binary-extensions-1.8.0.tgz:
Request failed \"502 B
501 - 600 of 1674 matches
Mail list logo
