[GitHub] zeppelin pull request #2017: [ZEPPELIN-1746] Flaky test: PySparkInterpreterT...

2017-02-13 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2017 [ZEPPELIN-1746] Flaky test: PySparkInterpreterTest ### What is this PR for? PySparkInterpreter (and PySparkInterpreterMatplotlibTest, SparkInterpreterTest, SparkSqlInterpreterTest) test

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

2017-02-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2006 Okay, maybe then stick to black-grey, and see how it looks and improve later? Having label sounds good as well. maybe we can try put small npm logo. --- If your project is set up

[GitHub] zeppelin issue #2009: [ZEPPELIN-2101] Add zeppelin bump up and git tag scrip...

2017-02-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2009 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...

2017-02-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1983 Thanks @soralee for the fix. Tested manually and it works well as expected. LGTM. Master branch is little bit different from branch-0.7 so i can not apply this patch to branch

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

2017-02-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2006 It's nit. I think 'grey' can give impression that something is disabled or unavailable when it is compared to 'blue'. What do you think? Will there be any better way visually distinguish

[GitHub] zeppelin pull request #2015: [ZEPPELIN-2103] Unnecessary read from Helium re...

2017-02-13 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2015 [ZEPPELIN-2103] Unnecessary read from Helium registry ### What is this PR for? Every `Helium.getAllPackageInfo()` call read helium package information from all registry configured (both

[GitHub] zeppelin issue #2005: [ZEPPELIN-2084] z.show doesn't show dataframe

2017-02-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2005 CI failure is not related to this change. Merge to master and branch-0.7 if no more more comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1987: [ZEPPELIN-2068] Change interpreter.json & credentials....

2017-02-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1987 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2003: [ZEPPELIN-2058] Reduce travis build time

2017-02-10 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/2003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2003: [ZEPPELIN-2058] Reduce travis build time

2017-02-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2003 The [test passes](https://travis-ci.org/Leemoonsoo/zeppelin/builds/200218542) in my travis account. Recently, travis concurrent build assigned to Zeppelin is reduced to 5 from 11

[GitHub] zeppelin issue #1990: [ZEPPELIN-2072] Home Screen doesn't work on shiro.

2017-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1990 Thanks @soralee for the fix! Tested and LGTM. CI failure looks not related. Merge to master if no further discussions. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1986: [ZEPPELIN-2078] bug fix in get project name in Kylin i...

2017-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1986 CI failure looks not related. LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...

2017-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1886 LGTM and merge to master if no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2003: [ZEPPELIN-2058] Reduce travis build time

2017-02-09 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2003 [ZEPPELIN-2058] Reduce travis build time ### What is this PR for? This PR reduces travis build time | Test profile| Before (rough avg min) | After (rough avg

[GitHub] zeppelin issue #1992: ZEPPELIN-2083: default interpreter list should honour ...

2017-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1992 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1952 @1ambda further discussion about "how interpreter access data from other interpreter" can be done in https://issues.apache.org/jira/browse/ZEPPELIN-2019. Merge this PR

[GitHub] zeppelin issue #1987: [ZEPPELIN-2086] Change interpreter.json & credentials....

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1987 I think correct issue id is ZEPPELIN-2068. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1952 @1ambda Thanks for taking a look. Regarding query directly over the TableData in the ResourcePool, it depends on each interpreter. For example, SparkInterpreter can implement

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1952 @1ambda do you have any comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1981: [ZEPPELIN-2067] SparkInterpreter prints unnecessary ne...

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1981 Thanks @felixcheung @prabhjyotsingh @zjffdu taking a look. Merge to master if no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1971: When gear icon is clicked, scroll the page to the top ...

2017-02-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1971 Thanks @beriaanirudh for ux improvement! Looks good to me. Merge to master if no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1970: ZEPPELIN-2045. Pass interpreter properties with "spark...

2017-02-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1970 Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1981: [ZEPPELIN-2067] SparkInterpreter prints unneces...

2017-02-06 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1981 [ZEPPELIN-2067] SparkInterpreter prints unnecessary newline ### What is this PR for? Spark interpreter prints unnecessary new line before the evaluation output is printed. See https

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1975 @zjffdu Created an issue to address unnecessary newline from SparkInterpreter https://issues.apache.org/jira/browse/ZEPPELIN-2067 Merge this PR to master if no further discussions

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1975 @zjffdu If you take a look https://github.com/apache/zeppelin/blob/master/notebook/2A94M5J1Z/note.json#L89, you'll see there're two new lines between outputs. Spark interpreter (scala) seems

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1975 @zjffdu If blank lines of output is output from "import ..." in Scala, that's slightly different issue. Otherwise, please give me an example --- If your project is set up for i

[GitHub] zeppelin issue #1967: [ZEPPELIN-2042] Document how to run selenium test

2017-02-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1967 @felixcheung Thanks. Merge to master if no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1973: [gh-pages][ZEPPELIN-2055] Add "What's new in 0.7" and ...

2017-02-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1973 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1973: [gh-pages][ZEPPELIN-2055] Add "What's new in 0.7" and ...

2017-02-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1973 @AhyoungRyu Great! nit: While this will be seen from not only existing Zeppelin user but also people new to Zeppelin, how about change "Interpreter Per User /

[GitHub] zeppelin issue #1974: [ZEPPELIN-2000][HOTFIX] Run paragraph on ng-change whe...

2017-02-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1974 fyi, this behavior change is introduced in #1647. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1970: ZEPPELIN-2045. Pass interpreter properties with "spark...

2017-02-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1970 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1973: [gh-pages][ZEPPELIN-2055] Add "What's new in 0.7" and ...

2017-02-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1973 Looks great! What do you think add things about improvements on Python/pyspark in what's new section? Matplotlib integration in python/pyspark and conda support in python

[GitHub] zeppelin issue #1972: [WIP][DOC] 0.7.0 release note

2017-02-04 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1972 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-02-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 @karuppayya Great work! LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1969: [ZEPPELIN-1465] Add an option to allow S3 server-side ...

2017-02-03 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1969 Thanks @jeff-cyft for the contribution! LGTM and merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1962: [ZEPPELIN-2014] Jetty Directory Listing on app, assets...

2017-02-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1962 @vboginskii Thanks for the contribution. LGTM and merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-02-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 @karuppayya could you try following change? ``` --- a/zeppelin-server/src/test/java/org/apache/zeppelin/AbstractZeppelinIT.java +++ b/zeppelin-server/src/test/java/org/apache

[GitHub] zeppelin pull request #1967: [ZEPPELIN-2042] Document how to run selenium te...

2017-02-01 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1967 [ZEPPELIN-2042] Document how to run selenium test ### What is this PR for? This PR document how to run selenium test in development environment ### What type of PR

[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...

2017-02-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1886 CI failure is not related to this change. LGTM and merge to master if no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-02-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 @karuppayya sure, let me take a look selenium test in this branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1963: [ZEPPELIN-2033] Handle focus/blur of paragraph with hi...

2017-02-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1963 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #:

2017-01-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/zeppelin/commit/c2a91e96c72aad020435dfd986b6888c73a4d029#commitcomment-20689676 This PR has merged and available on master and branch-0.7 --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1804 Tested and LGTM. Merge to master and branch-0.7 if no further discussions. When authentication is turned on, custom home is not loaded after the login without refresh the browser

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 @1ambda Awesome new feature! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.getAllRes...

2017-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1958 Merge to master if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDri...

2017-01-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1959 Merge to master if no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 Thanks addressing the comments. Tested and it works well as expected. Agree, 1) can be handled in separate issue while this PR already quite big. CI fails on RAT check profile

[GitHub] zeppelin pull request #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.ge...

2017-01-29 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1959 [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDriver() fails with Unable to locate element 'WebSocket Connected' ### What is this PR for? Selenium test sometimes fails

[GitHub] zeppelin pull request #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.ge...

2017-01-29 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1958 [MINOR] Prevent log NPE in ResourcePoolUtils.getAllResourcesExcept() ### What is this PR for? ResourcePoolUtils.getAllResourcesExcept() sometimes throws NPE. Which doesn't really

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 last CI run fails with ``` Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 228.978 sec <<< FAILURE! - in org.apache.zeppelin.integration.Paragraph

[GitHub] zeppelin issue #1951: [ZEPPELIN-2020] Invoke method from resource

2017-01-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1951 Merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 @karuppayya tried again with clean build and i don't see problem now. Maybe my test branch has been messed up. Now, two CI profiles are failing https://travis-ci.org/apache

[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 CI failure looks unrelated, since it only removed commented-out code from last CI success. Thanks @bbonnin for great contribution. LGTM and merge to master if no further discussions

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 The behavior from GIF is, When spark job is run in `%spark` paragraph, runtime info is displayed correctly. After that, if the same paragraph is reused for other interpreter (e.g

[GitHub] zeppelin issue #1936: [ZEPPELIN-2004] List all helium packages in Zeppelin G...

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1936 Thanks @AhyoungRyu for review. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1804 @soralee Tested the last commit. but empty screen is displayed when i set `ZEPPELIN_NOTEBOOK_HOMESCREEN`. Could you check? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1949 LGTM and merge to master if no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1948: [ZEPPELIN-2016] add test case for cron job scheduler r...

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1948 @khalidhuseynov Cool! LGTM and merge to master if no more comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #1952: [ZEPPELIN-753] TableData abstraction

2017-01-26 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1952 [ZEPPELIN-753] TableData abstraction ### What is this PR for? This PR implements TableData abstraction that every interpreter can use to share data through resource pool. This PR

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 Thanks @1ambda for contributing very interesting new feature. I've play around with it and have couple of feedbacks. ### Couldn't make Spell as display system work > The m

[GitHub] zeppelin issue #1936: [ZEPPELIN-2004] List all helium packages in Zeppelin G...

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1936 @AhyoungRyu Updated the doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1804 It's nit. But do you mind change some file name? `zeppelin-web/src/app/home/customer/customHome.html` -> `zeppelin-web/src/app/home/notebook.html` I think we don't need `custo

[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1892 cc @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 LGTM @1ambda do you have any comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1949 @DrIgor Thanks for the contribution! CI fails with known flaky test https://issues.apache.org/jira/browse/ZEPPELIN-1856. @DrIgor Could you trigger ci again and see if it passes

[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1924 @astroshim do you mind create a JIRA issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1924 LGTM and merge to master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1951: [ZEPPELIN-2020] Invoke method from resource

2017-01-26 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1951 [ZEPPELIN-2020] Invoke method from resource ### What is this PR for? This PR provides a way to invoke method remotely against the resource in the resource pool

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 Sorry for coming back late. Tested the last commit and looks good to me. @karuppayya could you merge master and resolve the conflict and see if CI becomes green? Then i'd like to merge

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1944 my command is ``` /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/bin/java -agentlib:jdwp=transport=dt_socket,address=127.0.0.1:6,suspend=y,server=n

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-01-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1944 I don't have special configuration for Intellij but does not have any problem after Helium. If you run following command, you'll see all dependencies of `zeppelin-server` module

[GitHub] zeppelin issue #1942: [ZEPPELIN-1982] When using the 'Select * ...' statemen...

2017-01-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1942 Thanks @del680202 for the fix! Although it fixes problem from of output from SparkInterpreter, outputs from other interpreters may have the same problem unless other interpreter

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-01-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1944 Im always running ZeppelinServer from intellij without this change. Am I missing something ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1930: [ZEPPELIN-1886] implementation z.getZeppelinJobStatus

2017-01-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1930 Could you rebase/merge master and see if CI passes? This branch has a lot of CI build failure which is fixed by https://github.com/apache/zeppelin/pull/1939 --- If your project

[GitHub] zeppelin issue #1935: [gh-pages][ZEPPELIN-1973] List all available Helium pa...

2017-01-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1935 Tested and works as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1939: [ZEPPELIN-2007] Fix flaky test: ShellInterpreterTest#t...

2017-01-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1939 I'm merging this to master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1939: [ZEPPELIN-2007] Fix flaky test: ShellInterprete...

2017-01-24 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1939 [ZEPPELIN-2007] Fix flaky test: ShellInterpreterTest#testShellTimeout ### What is this PR for? Fix flaky test ShellInterpreterTest#testShellTimeout https://issues.apache.org/jira/browse

[GitHub] zeppelin pull request #1936: [ZEPPELIN-2004] List all helium packages in Zep...

2017-01-23 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1936 [ZEPPELIN-2004] List all helium packages in Zeppelin GUI ### What is this PR for? ZEPPELIN-1973 will provides catalogue for all available helium (visualization) packages in npm registry

[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...

2017-01-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1833 Tested. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1808: [ZEPPELIN-1843] Error on invoking the REST API to run ...

2017-01-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1808 Merge it master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1919: [ZEPPELIN-1986] Fix flaky test: Increase WelcomePageSu...

2017-01-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1919 @jongyoul I don't have any good idea except for change test to use less resources when travis is under resource starvation. Do you have any good idea? --- If your project is set up

[GitHub] zeppelin issue #1931: [ZEPPELIN-1984] Capture stdin/stdout on interpreter pr...

2017-01-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1931 Thanks @felixcheung @Tagar reviewing it. Merge to master if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1921: [ZEPPELIN-1984] Zeppelin Server doesn't catch all exce...

2017-01-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1921 @Tagar thanks, merge to master if no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1921: [ZEPPELIN-1984] Zeppelin Server doesn't catch all exce...

2017-01-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1921 Change LGTM. Recently there were some fixes for CI. @Tagar Could you rebase this PR and see if CI build goes green? And i implemented propagating actual cause to front-end

[GitHub] zeppelin pull request #1931: [ZEPPELIN-1894] Capture stdin/stdout on interpr...

2017-01-21 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1931 [ZEPPELIN-1894] Capture stdin/stdout on interpreter process creation and propagate to front-end when error ### What is this PR for? This PR captures stdin/stdout on interpreter process

[GitHub] zeppelin issue #1913: [ZEPPELIN-1979] fix 'File size limit Exceeded' when im...

2017-01-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1913 LGTM and merge to master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1927: [ZEPPELIN-1994] bugfix of streaming output.

2017-01-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1927 Great fix. LGTM. Merge to master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.

2017-01-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1924 @astroshim following test failure might related. Could you check? ``` Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 19.978 sec <<<

[GitHub] zeppelin issue #1908: [ZEPPELIN-1976] Text-Output too large, causing crash

2017-01-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1908 Merge to master when no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1925: [ZEPPELIN-1749] Fix Flaky test: in Websequence markdow...

2017-01-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1925 CI green. Merge to master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1925: [ZEPPELIN-1749] Fix Flaky test: in Websequence ...

2017-01-20 Thread Leemoonsoo
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/1925 [ZEPPELIN-1749] Fix Flaky test: in Websequence markdown plugin ### What is this PR for? Fix flaky test n Websequence markdown plugin. Test is failing when request to websequence

[GitHub] zeppelin pull request #1925: [ZEPPELIN-1749] Fix Flaky test: in Websequence ...

2017-01-20 Thread Leemoonsoo
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/1925 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1923: [ZEPPELIN-1857] Fix flaky test: NotebookTest.testAbort...

2017-01-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1923 Merge to master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1925: [ZEPPELIN-1749] Fix Flaky test: in Websequence ...

2017-01-20 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1925 [ZEPPELIN-1749] Fix Flaky test: in Websequence markdown plugin ### What is this PR for? Fix flaky test n Websequence markdown plugin. Test is failing when request to websequence

[GitHub] zeppelin issue #1920: [ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTes...

2017-01-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1920 Merge it as a hot fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1920: [ZEPPELIN-1455] Fix flaky test: AbstractAngular...

2017-01-20 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1920 [ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTest ### What is this PR for? This PR fix flaky test [ZEPPELIN-1455](https://issues.apache.org/jira/browse/ZEPPELIN-1455

[GitHub] zeppelin pull request #1919: Increase WelcomePageSuite timeout

2017-01-20 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1919 Increase WelcomePageSuite timeout ### What is this PR for? Try fix problem described in https://issues.apache.org/jira/browse/ZEPPELIN-1986. Almost all recent build has this failure

[GitHub] zeppelin issue #1916: [WIP] [ZEPPELIN-1986] WelcomePageSuite test fail

2017-01-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1916 @jongyoul just wanted make sure the failure is coming from `WelcomePageSuite` it self, not as a side effect of other problems. I'll close this PR and open another PR once i found fix

[GitHub] zeppelin pull request #1916: [WIP] [ZEPPELIN-1986] WelcomePageSuite test fai...

2017-01-20 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1916 [WIP] [ZEPPELIN-1986] WelcomePageSuite test fail ### What is this PR for? Try fix problem described in https://issues.apache.org/jira/browse/ZEPPELIN-1986. Almost all recent build has

[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-01-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1911 Thanks @DrIgor for fix and explanation of the issue! When RemoteInterpreterServer creates Interpreter, it [wraps interpreter instance with LazyOpenInterpreter](https://github.com

<    3   4   5   6   7   8   9   10   11   12   >