[GitHub] zeppelin issue #2296: [ZEPPELIN-2463] Avoid Locking interpreterSettings duri...

2017-05-02 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2296 @Leemoonsoo , Could you please take a look at this change ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2310: ZEPPELIN-2484 do a Null check before calling tr...

2017-05-02 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2310 ZEPPELIN-2484 do a Null check before calling trim on paragraph's text ### What is this PR for? Prevent NullPointerException during check to determine whether a new paragraph nee

[GitHub] zeppelin issue #2301: [ZEPPELIN-1625] Override Interpreter settings at User ...

2017-05-01 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2301 @zjffdu , Thanks for pointing me to ZEPPELIN-1338. I did not know about it. I believe, the intent is same. I agree that the approach is different. We wanted to shield the user from

[GitHub] zeppelin issue #2296: [ZEPPELIN-2463] Avoid Locking interpreterSettings duri...

2017-05-01 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2296 @prabhjyotsingh , Could you please review this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2301: [ZEPPELIN-1625] Override Interpreter settings at User ...

2017-05-01 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2301 @Leemoonsoo , Could you please review this feature ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2297: [ZEPPELIN-2465] Minor code fixes for the livy package

2017-04-28 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2297 @zjffdu , could you please review this change ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2301: [ZEPPELIN-1625] Override Interpreter settings a...

2017-04-28 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2301 [ZEPPELIN-1625] Override Interpreter settings at User level ### What is this PR for? When multiple users share a zeppelin instance, it is sometimes desirable to use the same interpreter

[GitHub] zeppelin pull request #1623: ZEPPELIN-1625 add support for user specific pro...

2017-04-28 Thread benoyantony
Github user benoyantony closed the pull request at: https://github.com/apache/zeppelin/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2297: [ZEPPELIN-2465] Minor code fixes for the livy p...

2017-04-27 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2297 [ZEPPELIN-2465] Minor code fixes for the livy package ### What is this PR for? Minor code fixes for the livy package. The code fixes include : Fixing a typo in a classname

[GitHub] zeppelin pull request #2296: [ZEPPELIN-2463] Avoid Locking interpreterSettin...

2017-04-27 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2296 [ZEPPELIN-2463] Avoid Locking interpreterSettings during Notebook deletion ### What is this PR for? Deletion of a notebook requires locking interpreterSettings. If the deletion is

[GitHub] zeppelin pull request #2295: [ZEPPELIN-2463] Avoid Locking interpreterSettin...

2017-04-27 Thread benoyantony
Github user benoyantony closed the pull request at: https://github.com/apache/zeppelin/pull/2295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2295: [ZEPPELIN-2463] Avoid Locking interpreterSettin...

2017-04-27 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2295 [ZEPPELIN-2463] Avoid Locking interpreterSettings during Notebook deletion ### What is this PR for? Deletion of a notebook requires locking interpreterSettings. If the deletion is

[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements

2017-04-16 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2223 Thanks @zjffdu for reviewing and committing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements

2017-04-10 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2223 A testcase errored out and it seems to be unrelated. ParagraphActionsIT.testRunOnSelectionChange --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements

2017-04-04 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2223 @zjffdu , Will try to add the unit test for cancellation in LivySparkSQLInterpreter. Any suggestion on how to simulate a sleep in SQL ? Also, where are the other comments ? Sorry, I am

[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements

2017-04-04 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2223 @zjffdu , Could you please review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2223: [ZEPPELIN-2355] Livy cancel enhancements

2017-04-04 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2223 [ZEPPELIN-2355] Livy cancel enhancements ### What is this PR for? The Cancel functionality for the Livy interpreter has a couple of issues. One issue is because a variable is not

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-04-03 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 Thank you @zjffdu and @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-03-31 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 It should not break anything as the property name remains same as before. The documentation had a typo in it. It was missing 'sql' in it. If it's confusing, I

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-03-30 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 Thanks for the prompt review, @zjffdu . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-03-30 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 @felixcheung , Could you please help commit this patch ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-03-30 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 That seems to have worked. thanks @zjffdu . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-03-30 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 I had retriggered it once. Doing it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

2017-03-30 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/2201 There seems to be a problem with Jenkins as the error is " java.io.IOException: Remote call on ubuntu-2 failed". Any idea on howto overcome this ? The travis build has

[GitHub] zeppelin pull request #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should us...

2017-03-28 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/2201 [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.show(1000, false)… … to display results ### What is this PR for? Livy SQL interpreter truncate result strings of size

[GitHub] zeppelin issue #1778: ZEPPELIN-1834 Deadlock in Zeppelin when running multip...

2016-12-17 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/1778 When a note is run as by scheduler, thread T1 calls Note.runAll() and lock on the paragraphs is acquired. Later, T1 tries to obtain locks on paragraphs of other notes as part of status

[GitHub] zeppelin pull request #1778: ZEPPELIN-1834 Deadlock in Zeppelin when running...

2016-12-16 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/1778 ZEPPELIN-1834 Deadlock in Zeppelin when running multiple notes via sc… ### What is this PR for? What is this PR for? To prevent deadlock when different notes are run simultaneously

[GitHub] zeppelin issue #1623: ZEPPELIN-1625 add support for user specific properties

2016-11-17 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/1623 thanks @1ambda , Sorry for the delay. 1. If this feature is merged, then the properties can be referred in the interpreter properties. Each user can override the property value

[GitHub] zeppelin pull request #1623: ZEPPELIN-1625 add support for user specific pro...

2016-11-11 Thread benoyantony
Github user benoyantony closed the pull request at: https://github.com/apache/zeppelin/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1623: ZEPPELIN-1625 add support for user specific pro...

2016-11-11 Thread benoyantony
GitHub user benoyantony reopened a pull request: https://github.com/apache/zeppelin/pull/1623 ZEPPELIN-1625 add support for user specific properties ### What is this PR for? User should be able to define properties and these properties must be passed to Interpreter via

[GitHub] zeppelin pull request #1623: ZEPPELIN-1625 add support for user specific pro...

2016-11-11 Thread benoyantony
Github user benoyantony closed the pull request at: https://github.com/apache/zeppelin/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1623: ZEPPELIN-1625 add support for user specific pro...

2016-11-11 Thread benoyantony
GitHub user benoyantony reopened a pull request: https://github.com/apache/zeppelin/pull/1623 ZEPPELIN-1625 add support for user specific properties ### What is this PR for? User should be able to define properties and these properties must be passed to Interpreter via

[GitHub] zeppelin issue #1611: ZEPPELIN-1625 - Add support of user specific propertie...

2016-11-11 Thread benoyantony
Github user benoyantony commented on the issue: https://github.com/apache/zeppelin/pull/1611 Opened a new pull - https://github.com/apache/zeppelin/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1611: ZEPPELIN-1625 - Add support of user specific pr...

2016-11-11 Thread benoyantony
Github user benoyantony closed the pull request at: https://github.com/apache/zeppelin/pull/1611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1623: ZEPPELIN-1625 add support for user specific pro...

2016-11-11 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/1623 ZEPPELIN-1625 add support for user specific properties ### What is this PR for? User should be able to define properties and these properties must be passed to Interpreter via

[GitHub] zeppelin pull request #1611: ZEPPELIN-1625 - Add support of user specific pr...

2016-11-07 Thread benoyantony
GitHub user benoyantony opened a pull request: https://github.com/apache/zeppelin/pull/1611 ZEPPELIN-1625 - Add support of user specific properties ### What is this PR for? User should be able to define properties and these properties must be passed to Interpreter via