Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
A quick search over JIRA suggests that the failure you reffer was taked
care of in [ZEPPELIN-1264](https://issues.apache.org/jira/browse/ZEPPELIN-1264)
and is resolved in latest master, please rebase
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1266
Great improvement @AhyoungRyu ! Posted few suggestions above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1263
CI failed due to
[ZEPPELIN-1264](https://issues.apache.org/jira/browse/ZEPPELIN-1264)
Rebasing on latest master and merging, if there is no further discusison
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1267
Looks great to me, thank you @bustios !
Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1261
Have created
[ZEPPELIN-1269](https://issues.apache.org/jira/browse/ZEPPELIN-1269)
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1261
Have updated the comment, you might need to reload the page
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1261
Local build results are - it hangs for last 4 minutes with the error below
```
20:56:59,101 INFO org.apache.zeppelin.notebook.Paragraph:282 - run
paragraph 20160802-205659_1961452200
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1261
CI seems to not beeing triggered on this branch :\
Trying locally with `time mvn package -pl "\!zeppelin-distribution"`
---
If your project is set up for it, you can reply to
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1227
Looks great to me! Merging if there is no further discussion.
> Does this needs documentation? no
I think it does ;)
---
If your project is set up for it, you can re
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge on the architecture side - could you please elaborate on the
design that you choose, especially regarding `TorrentServlet` - why do you need
a new servlet? What are the parts
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
@khalidhuseynov thank you!
Do you suggest merging this guy now and taking care of Revision separation
later?
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1260
\cc @jongyoul for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
ð for having a test!
Looks good to me, modulo the issue raised above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1259
Looks great to me, modulo question above.
Thank you for prompt fix @Leemoonsoo !
Shall this be merged to master or branch-0.6 as well? Asking as JIRA fix
version is not set for this one
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1258
Would it make sense to change `isParagraphSaveAlready` =>
`wasParagraphAlreadySaved` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Sorry, was quite a busy week.
Great progress so far, from the first glance and on the formal side of the
contribution:
1. CI is failing, could you please post here the reason
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1239
Looks great to me.
CI failure:
```
[INFO] Zeppelin: web Application .. FAILURE [02:13
min]
...
[INFO] Running 'grunt build --no-color' in
/home/travis
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
@khalidhuseynov glad to hear. But CI is red again, could you, as an author
of PR please post here the reason of failure? This will save time for the
reviewers.
And thank you for kind
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1249
Looks great to me.
>I think it would be nice to show a column with the row number or index if
the DataFrame had one.
@bustios This makes sense, please feel free to open a separ
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1244
Looks great to me. :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
@khalidhuseynov could you please elaborate on CI failure reason?
Also, could you please explain why do you think this is valuable change and
what benefits does it bring?
---
If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1247
@r-kamath if you are planning to add more changes in this PR, do you think
it will make sense to:
- update TODO list in PR description with action items that you plan
- add `WIP` prefix
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1253
Thank you so much for taking care!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1249
Looks great to me, @bustios could you add a simple test case that reproduce
this case to the
[python/src/test/java/org/apache/zeppelin/python/PythonInterpreterPandasSqlTest.java](https://github.com
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Got it, makes perfect sense! Thank you for updating error handling and the
plan to address external auth cfg later sounds good.
Looks great to me, merging to *master* and *branch-0.6
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Thank you! Sounds awesome to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Added babupe/zeppelin#2
After configuring credentials I got strange behavior: query `show tables`
results is `ERROR` paragraph status with
- no output in GUI
- and nothing
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
While running locally I got:
```
ERROR [2016-07-29 15:05:09,591] ({pool-2-thread-2}
BigQueryInterpreter.java[open]:142) - Cannot open connection
java.io.IOException: The Application
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
CI build failed due to networking issues
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.4:process (default) on
project zeppelin: Error
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
So what do you guys suggest we do @corneadoug @lresende ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1238
Thanks for the prompt review, merging if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1238
Merging it ASAP as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Do you think we should merge it as is and address eclipse formatter in the
separate issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1235
Looks great to me, modulo CI failure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1229
Looks good to me.
\cc @corneadoug to double-check
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Thank you for sharing the progress! Let me look into this and get back to
you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the pull request:
https://github.com/apache/zeppelin/commit/5a4aacef25b0b54d151cfc7a3ea81cc312f6f655#commitcomment-18424229
In jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
In jdbc/src/main/java/org/apache/zeppelin/jdbc
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1201
Looks great to me!
CI fails on
```
[INFO] Zeppelin: Display system apis .. FAILURE [
24.426 s]
[31m- should provide onclick method *** FAILED ***[0m
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1213
Looks awesome! @sixmen thank you for taking care
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Looks great to me, thank you!
I'll do a final pass and play with it more today.
Will merge it right after, if there is no further discussion.
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1117
Sorry, it took me a while to get back. Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1211
@rerngvit thank you for contributing! Please check if I have correctly
assigned JIRA id for this issue to keep attribution.
---
If your project is set up for it, you can reply to this email and have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1211
Looks good to me.
CI failure is due to flaky R test and is treked under
[ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862)
Merging if there is no further discussion
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1212
Looks great to me. Let's merge if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1160
Looks good to me, merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Great, thank you for understanding, we are almost there. I have marked
above ones that I was able to verify, could you please double-check it?
On the `com.google.apis:google-api-services
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
As transitive dependecies in compile scope got included in final release
convenience binary, all licenses need to be included to
[zeppelin-distribution/src/bin_license/LICENSE](https://github.com
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
I see, generated source code is not available, thank you for clarification!
So we should assume that we are including in the Apache Zeppelin release
convenience binary a non-opensource third-party
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1160
Great improvement! In this case WS protocol improvement makes sense indeed.
ð for tests
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1192
Looks great to me! Thank you for taking care. Megin if there is no further
discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Looks great to me, thank you for taking care!
I think now the only thing that is left, is to determine the status of
dependency:
```
com.google.apis
google-api-services
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1199
Looks good to me. CI is green now.
AFAIK it's not possible to use Selenium with Safari that easy as it
requires signed browser extension. Firefox 31 should work well though.
---
If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Great, thank you! Please, let me make a final pass and I'll get back to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1172
Looks great to me, and CI is green now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
CI is failure
[logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/145344524/log.txt)
is not relevant and is tracked in
[ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
> So, you may have to run the tests manually from a GCE instance after
setting a project id in resources/constants.json.
>After this, running the test with -Dbigquery.test.exclude='' will
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Regarding
>Is it ok if I do the following,
> 1. Create a NOTICE file in the root of bigquery project. i.e
./bigquery/NOTICE and add something like
https://github.com/apache/incubato
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Thanks @babupe I think we are almost there! Did another pass and add few
last things above.
One more thing I noticed is - right now this PR fails the project's CI
build and we heavily rely
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1192
Looks like CI fails, could you please followup on the reason?
One more question - it looks like this PR not only add websocket API but
change backend API and modify every NotebookRrpo
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1183
LGTM. Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
@babupe great job, I have highlighted few issues inline in code above.
I would really appreciate if, for the sake of maintainability, you could
please add `./bigquery/README.md` with some
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
@babupe thank you for taking care. @AhyoungRyu thank you for review.
Let me do another pass on it and get back to you.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1164
Done, merging after CI â»ï¸ if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/747
@Leemoonsoo could you into non-trivial merge conflicts that happen on
merging to `branch-0.6` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/928
Got it, thank you so much for digging into it!
Let me try to look into it more this week
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1164
Thank you guys for prompt reviews!
Have added one minor TODO item to cleanup test profiles on CI, will merge
after #747
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1162
Thank you for pointing out Lens case!
May be we could extract this error handling logic to the method and re-use
it everywhere, so the client code would look like:
```java
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1117
What I mean is - as a user, when I auto-complete the interpreter name, I
would expect a suggestion list that contains only interpreter names and nothing
else.
Right now list of suggestion
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1182
@corneadoug from what you say, it's still not clear what's the plan with
this one.
I do not think it was rebased, where `rebased = git rebase` - that way all
the commits would show up AFTER
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
I have applied `ZeppelinStyle` Java formatter in Eclipse and re-formatted
`ZeppelinServer.java` here is the diff below
```
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@jongyoul do you think we should update our documentation for contributors,
mentioning this IDE setup as well?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1182
So what is the consensus, shall we actually *rebase* this one on master and
merge, or just close, as soon as #1171 is merged?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/747
Looks great to me! Thank you @lresende
Let's merge if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1164
Documentation review addressed in e432961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1170
Great contribution, thank you!
Couple of questions on top of few one already raised above:
- will you be willing to add some tests as well? Looking at other
interpreters impl like #1164
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1117
@astroshim looks awesome, thank you for implementing!
How do you think, would it improve user experience with this feature if we
could remove from suggestion list things
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
ping, @onkarshedge are there any updates for the past week?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/747
Looks ð ð¯ to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1161
Looks good to me.
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1162
Current CI failure:
```
org.apache.zeppelin.elasticsearch.ElasticsearchInterpreterTest
org.apache.zeppelin.elasticsearch.ElasticsearchInterpreterTest Time
elapsed: 8.15 sec
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1120
CI is green now, looks great to me.
Can you please next time make sure JIRA issue is assigned to you as well?
Let me know if there are any troubles with JIRA on doing so (i.e it's not
editable
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1137
@astroshim can you please next time set "Fix Version" in JIRA and make sure
issue is assigned to you?
This helps release manager a lot!
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1137
Thank you for fixing! Looks like CI fails dues to
https://github.com/npm/npm/issues/13284
Looks good to me, merging if there is no more discussion
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1141
CI fails due to
https://github.com/npm/npm/issues/13284#issuecomment-230799479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge sorry, people were busy releasing 0.6.0 recently
Could you please:
- [ ] rebase this code on latest `master` branch
- [ ] update title (add WIP) and PR description
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/928
Looks at latest CI results, I do not think that comment above is relevant
any more, esp for the first and most general CI profile.
Great progress @rawkintrevo !
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1134
CI is green, merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1134
Reviews addressed in 65698d2, waiting for CI now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1120
ping @astroshim
To help making CI more stable, could you please re-base on the latest
master?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1136
I have updated JIRA issue, next time could you please make sure it's
assigned and have correct "Fix Version" set? This helps to do release
management a lot!
---
If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1125
Looks great to me ð for having tests!
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user bzz reopened a pull request:
https://github.com/apache/zeppelin/pull/1134
ZEPPELIN-1063: fix PythonInterpreter flaky test
### What is this PR for?
fix flaky `PythonInterpreter.testClose()` test
### What type of PR is it?
Hot Fix
### What
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1120
ð for adding a test!
Looks great to me, merging if there is no more dicsussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1131
Looks good to me, merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/418
Shall we wrap this work up?
AFAIK we just need to:
- rebased on the latest master
- address @felixcheung feedback
- merge the guy
---
If your project is set up for it, you can
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1134
Should fix build on master and #1100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1134
ZEPPELIN-1063: fix PythonInterpreter flaky test
### What is this PR for?
fix flaky `PythonInterpreter.testClose()` test
### What type of PR is it?
Hot Fix
### What
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1100
CI failure is not related and is fixed under
[ZEPPELIN-1063](https://issues.apache.org/jira/browse/ZEPPELIN-1063)
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
@khalidhuseynov what about latest CI failure on this PR? Licence check is
failing the build
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
(verify.rat
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
This looks very similar to
[ZEPPELIN-1063](https://issues.apache.org/jira/browse/ZEPPELIN-1063) with title
"Flaky Test - PythonInterpreterTest.testClose" wich I can not reproduc
301 - 400 of 535 matches
Mail list logo
