[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-27 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 @felixcheung Fixed. Thank you for the review. ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-26 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 ready to review ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-25 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 @felixcheung ping ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-23 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 @felixcheung Fixed. Please let me know if there are any other concerns. Thanks. ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-22 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 @felixcheung I addressed your comments. Case sensitive, and furthermore exact match are not required. thanks. ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-19 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 @zjffdu How about above felixcheung's comment? ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

2018-04-17 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 https://travis-ci.org/iijima-satoshi/zeppelin/builds/367533713 I tried to run travis ci several times. But #n.4 always failed with below errors. ``` The job exceeded the maximum

[GitHub] zeppelin pull request #2929: ZEPPELIN-3412 Enable query prefix syntax in big...

2018-04-17 Thread iijima-satoshi
GitHub user iijima-satoshi opened a pull request: https://github.com/apache/zeppelin/pull/2929 ZEPPELIN-3412 Enable query prefix syntax in bigquery interpreter ### What is this PR for? - interpreter Enable query prefix syntax in bigquery interpreter. Bigquery has a

[GitHub] zeppelin issue #2916: ZEPPELIN-3395 Fix impersonate spark interpreter withou...

2018-04-16 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2916 @felixcheung Fixed PR title. Thanks. ---

[GitHub] zeppelin issue #2916: ZEPPELIN-3395 Fix: Spark interpreter does not run as i...

2018-04-15 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2916 @felixcheung Please let me know if there are any other comments. Thanks. ---

[GitHub] zeppelin issue #2916: ZEPPELIN-3395 Fix: Spark interpreter does not run as i...

2018-04-12 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2916 Tests for interpreters except spark one were droped in case of ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER = true. I fixed and manually tested. ---

[GitHub] zeppelin issue #2916: ZEPPELIN-3395 Fix: Spark interpreter does not run as i...

2018-04-10 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2916 Could someone review this? Is it ok that this fix has no tests? This fix only includes interpreter.sh script. I manually tested it. ---

[GitHub] zeppelin pull request #2916: ZEPPELIN-3395 Fix: Spark interpreter does not r...

2018-04-09 Thread iijima-satoshi
GitHub user iijima-satoshi opened a pull request: https://github.com/apache/zeppelin/pull/2916 ZEPPELIN-3395 Fix: Spark interpreter does not run as impersonated user when disable… ### What is this PR for? Fix impersonate spark interpreter. Currently, impersonate spark

[GitHub] zeppelin issue #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 with had...

2018-04-09 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2904 The build with some patches including this fix has already completed on my environment. At bigtop build command, -Dhadoop.version argument is specified. Is this argument unnecessary

[GitHub] zeppelin issue #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 with had...

2018-04-08 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2904 I retried the tests and got another error ci: https://travis-ci.org/iijima-satoshi/zeppelin/builds/362086204 ``` [ERROR] Failed to execute goal net.alchim31.maven:scala-maven

[GitHub] zeppelin pull request #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 w...

2018-04-08 Thread iijima-satoshi
GitHub user iijima-satoshi reopened a pull request: https://github.com/apache/zeppelin/pull/2904 ZEPPELIN-3378 Dependency errors on hadoop 2.8 with hadoop2 profile ### What is this PR for? Fix dependency errors caused by different versions of the same libraries on zeppelin

[GitHub] zeppelin pull request #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 w...

2018-04-08 Thread iijima-satoshi
Github user iijima-satoshi closed the pull request at: https://github.com/apache/zeppelin/pull/2904 ---

[GitHub] zeppelin issue #2912: ZEPPELIN-3115 Fix bigquery interpreter to remove TAB a...

2018-04-06 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2912 green ci (https://travis-ci.org/iijima-satoshi/zeppelin/builds/363293521) ---

[GitHub] zeppelin issue #2912: ZEPPELIN-3115 Fix bigquery interpreter to remove TAB a...

2018-04-06 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2912 @felixcheung fixed up the PR title and added the test. ---

[GitHub] zeppelin pull request #2912: ZEPPELIN-3115 BigQuery interpreter does not ren...

2018-04-06 Thread iijima-satoshi
GitHub user iijima-satoshi opened a pull request: https://github.com/apache/zeppelin/pull/2912 ZEPPELIN-3115 BigQuery interpreter does not render the output of a sq… ### What is this PR for? Fix bigquery interpreter layout. The current layout is broken due to a tab

[GitHub] zeppelin issue #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 with had...

2018-04-04 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2904 Ok, I will try if it is fixed. ---

[GitHub] zeppelin issue #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 with had...

2018-04-03 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2904 @felixcheung Thank you for your review. Travis ci has passed except checkstyle violations which was caused by other commit. ---

[GitHub] zeppelin pull request #2904: ZEPPELIN-3378 Dependency errors on hadoop 2.8 w...

2018-04-02 Thread iijima-satoshi
GitHub user iijima-satoshi opened a pull request: https://github.com/apache/zeppelin/pull/2904 ZEPPELIN-3378 Dependency errors on hadoop 2.8 with hadoop2 profile ### What is this PR for? Fix dependency errors caused by different versions of the same libraries on zeppelin

[GitHub] zeppelin issue #2854: ZEPPELIN-3310. Scio interpreter layout is broken

2018-03-19 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2854 Thank you for the review and merge. ---

[GitHub] zeppelin issue #2854: ZEPPELIN-3310. Scio interpreter layout is broken

2018-03-19 Thread iijima-satoshi
Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2854 @felixcheung If no problem, could you merge this PR? ---

[GitHub] zeppelin pull request #2854: ZEPPELIN-3310. Scio interpreter layout is broke...

2018-03-09 Thread iijima-satoshi
GitHub user iijima-satoshi opened a pull request: https://github.com/apache/zeppelin/pull/2854 ZEPPELIN-3310. Scio interpreter layout is broken ### What is this PR for? Fix scio interpreter layout. The current scio interpreter layout is broken because there is not a newline