GitHub user yu74n opened a pull request:
https://github.com/apache/zeppelin/pull/2416
[ZEPPELIN-2647] Set admin user as owner when user create a notebook
### What is this PR for?
When a user creates a notebook, default users (an administrator can set
default users in zeppelin
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2416
[ZEPPELIN-2647] Set admin user as owner when user create a notebook
### What is this PR for?
When a user creates a notebook, default users (an administrator can set
default users in zeppelin
GitHub user yu74n opened a pull request:
https://github.com/apache/zeppelin/pull/2525
Make admin role to bypass auth logic
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What type of PR is it
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2416
@1ambda I created new PR for this issue. Could you check the new one?
I will close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2525
@1ambda thx
@felixcheung You are right, this feature affects all modes(private and
public). I don't understand public mode in detail, is there any problem if we
set admin role in public
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2525
One more thing. Should we set admin role to notebook owner in public mode?
I'm going to change this feature to set admin role to notebook owner, reader
and writer in private mode though.
-
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2525
I've fixed failed unit tests.
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2525
After fixed 'testSyncWithAcl', I manually restart CI. All test passed.
---
GitHub user yu74n opened a pull request:
https://github.com/apache/zeppelin/pull/2585
Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What type of PR is it
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
continued from #2525 #2416
---
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2585
---
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2585
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
@1ambda Sure
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
I rebased and ran test again, but this test is still failed.
https://travis-ci.org/yu74n/zeppelin/jobs/286508544
I think probably my PR doesn't affect the test.
I ran test se
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2585
---
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2585
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2585
---
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2585
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2585
---
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2585
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
test
---
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2585
---
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2585
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
Rerun all tests.
'testPerUserScopedAction' is passed this time, but other 4 tests is failed.
These 4 tests was passed before.
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
All tests are passed, but NotebookTest has an error.
java.lang.RuntimeException:
org.apache.thrift.transport.TTransportException: java.net.SocketException:
Connection reset
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
and rerun the failed travis job manually, the job is passed.
https://travis-ci.org/yu74n/zeppelin/jobs/295676369
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
What do you think about that? @1ambda @felixcheung
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
@felixcheung if unset zeppelin.notebook.default.owner.username, set 'admin'
as default value.
https://github.com/apache/zeppelin/pull/2585/files#diff-179ea3a816210bb9904baabec1a552e4R716
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
I've changed default value is blank.
if set blank as zeppelin.notebook.default.owner.username, disable admin
role.
---
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2585
---
GitHub user yu74n reopened a pull request:
https://github.com/apache/zeppelin/pull/2585
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all
notebooks.
### What
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
if set blank as default owner username, apply blank('') to the admin role.
but, I think, a user cannot set blank as login user name. so nearly equal as
disable admin role.
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
Actually, I thought so too when I explained how if the owner name is blank.
I've fixed that.
I've changed config template to be disable admin role.
Can you review
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2585
CI failed at testRunOnSelectionChange()
```bash
java.lang.AssertionError: Even if 'RunOnSelectionChange' is set as false,
still can run the paragraph by pressing ENTER
Exp
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2525
Close this PR because Continued at #2585
---
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2525
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2416
Close this PR because Continued at #2585
---
Github user yu74n closed the pull request at:
https://github.com/apache/zeppelin/pull/2416
---
GitHub user yu74n opened a pull request:
https://github.com/apache/zeppelin/pull/2695
[ZEPPELIN-3089] Create user folders under Trash folder
### What is this PR for?
In the situation where multi users a create notebook, "Empty Trash" button
next to "Trash" f
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2695
Yes, the default is anonymous.
Deleted files will be moved under ~Trash/anonymous/ folder.
---
Github user yu74n commented on the issue:
https://github.com/apache/zeppelin/pull/2695
Whether a user can find the notebook in trash or not is based on permission
of the notebook, then If user 'B' has properly permission for the notebook
deleted by user 'A', u
42 matches
Mail list logo