Re: [DISCUSS] semicolons in javascript

Have created a PR 2804 , which will force semicolon in JS. On 17 February 2018 at 19:22, Renjith Kamath wrote: > +1 for adding semicolons, makes the code more readable. > @prabhjyot we may need to review the whole eslintrc and improve the style > gui

Re: [DISCUSS] semicolons in javascript

+1 for adding semicolons, makes the code more readable. @prabhjyot we may need to review the whole eslintrc and improve the style guidelines. Thanks & Regards, RK On Sat, Feb 17, 2018 at 12:00 PM, Jongyoul Lee wrote: > Hi, > > I like to this kind of discussion. Currently, we don't have strict r

Re: [DISCUSS] semicolons in javascript

Hi, I like to this kind of discussion. Currently, we don't have strict rules for developing frontend and it might cause a problem. I hope you could summarize and fix all of these issues. Thanks, JL On Fri, Feb 16, 2018 at 10:02 PM, Prabhjyot Singh wrote: > Dear Zeppelin devs, > > In our curren

[DISCUSS] semicolons in javascript

Dear Zeppelin devs, In our current implementation of "eslintrc" semicolons disallow, and generally, there are two schools of thought. The first is that we should treat ASI as if it didn’t exist and always include semicolons manually. The rationale is that it’s easier to always include semicolons t

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2804 should this go to `dev@`? ---

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2804 @mebelousov I did not follow your comment. ---

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2804 @prabhjyotsingh it's great that one of PMC file such PR. A lot of tests show that JS works faster without syntax warnings. :+1: ---

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2804 cc: @1ambda @AhyoungRyu @r-kamath ---

[GitHub] zeppelin pull request #2804: [DISCUSS] semicolons in javascript

GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2804 [DISCUSS] semicolons in javascript ## What is this PR for? Have added this PR to discuss if we should add a rule in eslinerc to have semicolons in javascript source ### What