[GitHub] [zeppelin] zjffdu commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-06-04 Thread GitBox
zjffdu commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-498932357 Thanks for the info. @Tagar I think we could include the binary distribution of `libpty` as long as meet the `APPROPRIATELY LABELLED CO

[GitHub] [zeppelin] zjffdu commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-15 Thread GitBox
zjffdu commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492935457 @liuxunorg Based on the above comments, I think we should keep the old shell interpreter as the batch mode and the new shell interpreter as

[GitHub] [zeppelin] zjffdu commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter

2019-05-12 Thread GitBox
zjffdu commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-491682054 @liuxunorg Is it possible to download hterm_all.js at building time instead of put into repo ? And could you write a simple design doc for