Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
Thanks @cloverhearts @felixcheung @bzz taking a look.
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
Agreed. I think the model used in Spark is that if an API is:
- new
- expecting (significant) discussions/changes in this or the next minor
release
Then it should be "Exper
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
I think it can be decided by consensus. If community can not sure API will
stay unchanged until next major release (at least), it should be annotated as
'Experimental' otherwise we can
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
sounds good, but how does a contributor/developer decides whether something
new should be annotated as "Experimental" or "ZeppelinApi"?
---
If your project is set up for it, you can
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
@felixcheung
I have added @ZeppelinApi annotation to REST api endpoint.
Here's javadoc comment about two annotations.
ZeppelinApi
```
APIs exposed to
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
Documenting stable API with annotations looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
what's our guideline on what is experimental?
should that be added to
https://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/rest-api/rest-interpreter.html?
---
If
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
Looks goot to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
