Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@jongyoul @prabhjyotsingh I excluded `interpreter-setting.json` and also
rebased from master.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@AhyoungRyu have made a fix #4492.7 failed #958. Can you rebase with
master, and re-trigger ?
And yes other is `[INFO] Rat check: Summary of files. Unapproved: 1
unknown:
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@jongyoul I see. Okay Thanks for letting me know :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@AhyoungRyu One looks irrelevant and another is about rat plugin. you need
to exclude interpreter-setting.json in a rat plugin.
---
If your project is set up for it, you can reply to th
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
@jongyoul But CI is failed :( Is this relevant with this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/956
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or