[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...

2016-06-09 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/incubator-zeppelin/pull/966 Merging if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...

2016-06-09 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/incubator-zeppelin/pull/966 Looks great to me, let's merge as a short term solution. And yes, as @felixcheung mentioned - in a mid\long term, it would be great for interpreter to encapsulate this knowledge!

[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...

2016-06-07 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/incubator-zeppelin/pull/966 BTW, this PR looks good to me. We can discuss @felixcheung's issue after merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...

2016-06-07 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/incubator-zeppelin/pull/966 @felixcheung Could you please tell me your idea in details? Basically I agree with you, but I'm not good at frontend, I don't know whether the feature can be adopted dynamically or not.

[GitHub] incubator-zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for p...

2016-06-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/incubator-zeppelin/pull/966 LGTM btw, this is getting fragile - would be great if interpreter can have an extension mechanism to control what it is mapping to on the js side. --- If your project is set up