Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-222577855
@hriviere looks great to me, thank you for taking care!
Going to merge it, if there is no more discussion.
---
If your project is set up for it, you can
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-222577784
@hriviere I checked and it looks good ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hriviere commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-222549087
I made two commits :
* One to add a new line in python.md (cf. AhyoungRyu review)
* One to revert LICENSE file and to move py4j license from lic
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-222390840
@Leemoonsoo good point, and Py4j is already a part of out binary release fo
some time, so its been alredy listed in
'zeppelin-distribution/src/bin_license/LICENS
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-222370555
@hriviere Because py4j dependency will be included in binary release, not
in the source release, you'll need update py4j license under
'zeppelin-distribut
Github user hriviere commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-66087
* [ ] LICENSE needs to be updated to include all non-apache licensed
dependencies (i.e AFAIK Py4j is BSD )
@bzz Could you check that my
[commit](ht
Github user hriviere commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-64791
Hello,
Thanks for the reviews !
* [*] documentation updates needed, that @AhyoungRyu pointed out
* [x] double-check that code formatting
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-221808859
I think there is still a few documentation updates needed, that @AhyoungRyu
pointed out (i.e `{{BASE_PATH}}/interpreter/python.md` ->
`{{BASE_PATH}}/interpreter/
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-221159590
@AhyoungRyu thank you for detailed documentation review - we really need a
good docs for this new feature! ð for improving it
@hriviere thanks for gr
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/869#issuecomment-220886188
Hi @hriviere. Thanks for the really awesome feature! :)
Currently `python.md` is shown like below in Zeppelin docs site .
