[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-26 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221797090 @sagarkulkarni3592 could you please assign a JIRA issue to yourself? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/862 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-26 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221796281 Merging as it includes HOTFIX for failing Integration Tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-25 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221678686 Tested, Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221547422 Tested, works well. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-24 Thread sagarkulkarni3592
Github user sagarkulkarni3592 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221486053 @corneadoug Latest commit have both the changes you suggested. :) ![screen shot 2016-05-25 at 12 03 12 pm](https://cloud.githubusercontent.com/a

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-24 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221477983 @sagarkulkarni3592 "Started 2 minutes ago" looks more gracious :) --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-24 Thread sagarkulkarni3592
Github user sagarkulkarni3592 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221477528 @corneadoug So, it will be "a few seconds elapsed" or "2 minutes elapsed". It this good? --- If your project is set up for it, you can reply to th

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-24 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221477075 @sagarkulkarni3592 if you follow moment.js [documentation](http://momentjs.com/docs/#/displaying/fromnow/) You can use `fromNow(true)` to remove the `a

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-24 Thread sagarkulkarni3592
Github user sagarkulkarni3592 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221474937 @corneadoug Thank you for the suggestion. For a long running process, say running for more than hour, it will show something like "3601 seconds

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-24 Thread corneadoug
Github user corneadoug commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-221326854 I would prefer keeping the `elapsed` wording, otherwise it doesn't give indications that it is for the running process. --- If your project is set

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-23 Thread sagarkulkarni3592
GitHub user sagarkulkarni3592 reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/862 [ZEPPELIN-704] Display elapse time for long running paragraph ### What is this PR for? For long running paragraph, it is hard to know how long it has already been running

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-23 Thread sagarkulkarni3592
Github user sagarkulkarni3592 closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/862 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-704] Display elapse tim...

2016-05-23 Thread sagarkulkarni3592
Github user sagarkulkarni3592 commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/862#issuecomment-220963490 @prabhjyotsingh Thank you for the bug. Fixed this using standard ISO time format. Tested with different time zones. ![screen shot 2016-05-23 at