[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/911 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221152608 @astroshim Thank you for feed back. are you mean 'initial statement' is 'clean up on search box'? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221151213 Thanks for hotfix, but do we know why it stopped working in the first place? Let me take a look. \cc @felizbear for review as well --- If your

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221147514 @prabhjyotsingh fix done. Please, Can you feedback for this pr for me? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220962020 Or that is also broken for `$locationChangeSuccess`, its not cleaning up. Can you fix this as well ? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220959983 If we use `$scope.search = function(searchTerm)` then we can