Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1013
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
Thanks for the feedback all!
@Leemoonsoo After your explanation, it makes sense to display `anonymous`
@khalidhuseynov I added `WebSocket` because logged user can misunderstand
that he
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1013
I agree with @khalidhuseynov that having Connected/Disconnected being
replace by the username isn't great.
However I still think that showing a username cf: 'anonymous' for an app
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@khalidhuseynov Right. I totally agree with you.
@minahlee It's more intuitive than before ð
---
If your project is set up for it, you can reply to this email and have your
reply
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@khalidhuseynov Thanks for the feedback.
I totally agree that showing `Connected` message for non-logged user can be
confusing.
I made several changes based on your opinion.
- show
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1013
I've just went through the conversation here, and i think that having
`userName` instead of `connected` status in authenticated mode with additional
`logout` menu is quite misleading.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1013
CI failure is irrelevant to this change.
Tested and it looks good to me. +1 for merge it into master and branch-0.6
---
If your project is set up for it, you can reply to this email and
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1013
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
Updated selenium test and CI passes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
I am ok with either approach, seems like @corneadoug has strong opinion on
having two separate menu so I will leave it as it is. I will need to fix
selenium test to make it to be merged though.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1013
Ok, thanks for explanation, this was not a strong opinion, just a question.
Sounds good to me.
@minahlee what do you think?
---
If your project is set up for it, you can reply to this email
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@bzz In the case of Anonymous, I would really prefer keeping anything to do
with User Management out of Zeppelin if it's not using Auth. Since there is one
single user, there is no need for
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
I also don't feel the necessity of showing full user name since logged user
would know his own username. Let me remove username under dropdown then.
---
If your project is set up for it, you
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@minahlee Actually, the long name would normally be truncated by CSS
instead of javascript, so it wouldn't be good. (Since it was done elsewhere, no
need to fix it here)
Is it
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
Thanks for the feedback guys! I've just pushed some commits and updated
description with new screenshot.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@corneadoug thanks for posting screen! It looks reasonable
> and put every items under this single button?
> Either way, i think it's better than now.
True, as soon as it works on
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
One question, if `Confidential` is per user menu, should it be shown when
only user logged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@corneadoug Having separate menu for the anonymous user totally makes sense.
Then the next question would be where do we want to place it?
Next to Notebook? - will give less confusion who
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1013
> @bzz actually, last time I tested, the about dropdown was doing great on
mobile
Have you already tested 2 proposed dropdowns on mobile? If possible, plz
share the screenshots
---
If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1013
@bzz actually, last time I tested, the about dropdown was doing great on
mobile
@minahlee I still prefer separated one, mainly because you won't always
have a user, and
having a
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1013
Thanks @minahlee for the update. I think it's less confusing and more
organized way to manage menubar. Do you think it'll be merged into branch-0.6,
too?
On documentation, I think
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1013
I think this kind of menu should be under a setting icon instead.
And keep the admin dropdown element only for logout if there is auth
---
If your project is set up for it, you can reply
22 matches
Mail list logo
