[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...

2016-07-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1088 Thank you for taking care of it. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...

2016-07-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1088 @prabhjyotsingh Sorry for my late response. You're right. After just clicking `cancel`, it should focus on textbox again as you said. And regarding your second comment, I blocked ESC back drop

[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...

2016-06-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1088 Also what happens when user clicks on close ("x") button, instead of "OK" or "Close" ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] zeppelin issue #1088: [ZEPPELIN-1062] Get original InterpreterSetting when t...

2016-06-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1088 IMO, when user clicks on cancel after clicking on save; user should see the edit view back. --- If your project is set up for it, you can reply to this email and have your reply appear on