Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@corneadoug I rebased. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@astroshim Can you rebase with master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1104
Thank you for great feedback @corneadoug and prompt fixes @astroshim
Looks great to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1104
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1104
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@corneadoug Thank you for making clear. I fixed the code as you advised.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@astroshim Yes, its the best way for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@corneadoug
I thought it might be impacted but I didn't find a problem so I was waiting
these great review!
The implementation of the streaming feature in interpreters for the TEXT
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@bzz @astroshim
Took me quite some time to dig into this.
Removing `resultRefreshed` would have negative performances effect, its
original goal is to not re-render things if there
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1104
I'm currently writing a giant review as I'm testing things
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
@bzz Thank you for reviewing.
I think ```resultRefreshed``` condition causes bug and I don't know why it
needs.
@corneadoug @felizbear please review.
---
If your project is set up for i
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1104
So you think `resultRefreshed ` condition is not useful check any more?
\cc @felizbear @corneadoug for review
---
If your project is set up for it, you can reply to this email and have your
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1104
It seems that the CI fail is related to
https://github.com/apache/zeppelin/pull/1084.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
16 matches
Mail list logo
