[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-13 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1140 @prabhjyotsingh LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1140 @corneadoug should we merge this, so that, `grunt serve` starts working, and tune this later ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-10 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1140 @prabhjyotsingh I made a test PR with gif of Chrome, Firefox, Safari https://github.com/apache/zeppelin/pull/1159 --- If your project is set up for it, you can reply to this email and have you

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1140 > Basic Auth is getting logout after only one call. Kind of strange it, doesn't work for me. Have attached gif's where in console, first I'm trying to call it once, then twice, and

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-09 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1140 @prabhjyotsingh Basic Auth is getting logout after only one call. > Advantage of keeping UNAUTHORIZED is that we don't have to bother about $http.post's success, since just after that w

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-09 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1140 @corneadoug Shall I merge this, if it works for you ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1140 Yes, basic-auth was not getting logout on first call, hence I had to call it twice. Advantage of keeping `UNAUTHORIZED` is that we don't have to bother about $http.post's success, sinc

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-08 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1140 @prabhjyotsingh You are calling `$http.post` twice instead of once. Also, could you reverse the response message UNAUTHORIZED to OK, so that we can keep a success catch event when logout suc

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-08 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1140 @prabhjyotsingh Let me try again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1140 @corneadoug I tried your approach, it didn't worked for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] zeppelin issue #1140: [ZEPPELIN-1125] Application does not logout user when ...

2016-07-07 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1140 @prabhjyotsingh I got it fixed by only replacing the logout function in the front-end with: ``` $http.post(logoutURL) .error(function(response) { console.log('logout er