[GitHub] zeppelin issue #1159: [Test branch] Logout

2016-07-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1159 I don't have a strong view on any, fine either way. Just that I thought authcBasic should work. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1159: [Test branch] Logout

2016-07-11 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1159 @prabhjyotsingh If we can remove it, then maybe it would be nice to do so in the future. Especially since it makes the code more complicated. For now, let's go with #1140 --- If your

[GitHub] zeppelin issue #1159: [Test branch] Logout

2016-07-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1159 Agreed @corneadoug. Thought we don't have `authcBasic` in our doc, but whoever knows or had used shiro in past can choose to use it, and IMO whatever features shiro provides we should be

[GitHub] zeppelin issue #1159: [Test branch] Logout

2016-07-11 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1159 @prabhjyotsingh Oh, that's tricky, my initial comment was about authc. The fun thing is that authcBasic isn't even in the doc, nor as choice in the shiro.ini anymore. Do we still need