Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1160
Looks good to me, merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1160
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
addressed comments and CI is green. /cc @corneadoug @Leemoonsoo @bzz for
review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1160
Great improvement! In this case WS protocol improvement makes sense indeed.
ð for tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@khalidhuseynov I wanted to change the CSS for it, but I can't create any
checkpoints somehow
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@corneadoug how about this one 614ed61ab1b47bd5276d64d477983b605a25f6b8 :
https://cloud.githubusercontent.com/assets/1642088/16980145/82ffe7f6-4e9f-11e6-95ca-8c8202bae1be.png";>
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@corneadoug @Leemoonsoo @anthonycorbacho how about this one?
https://cloud.githubusercontent.com/assets/1642088/16978793/c2873624-4e98-11e6-910c-27977cb3ed98.png";>
---
If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@khalidhuseynov looks good, but i would reduce the font size and spacing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
okay, i'll play with it a bit then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@corneadoug @khalidhuseynov
Or how about align commit message left, and align date right and use fixed
length date format?
Then it gives little better readability i think.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@corneadoug yeah i changed the order since it's more intuitive to have name
first, and date afterwards. But you're right when too long name, the ellipse
doesn't look good. how do you think
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@khalidhuseynov Previous order in the list was: Date - Title, now it is
Title - Date.
As you can see in your screenshot, when the text gets too long, there is an
ellipse:
`add visu
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@corneadoug i'm not sure exactly what you mean, could you provide an
example?
@anthonycorbacho because:
* there're cases when backend will send the list triggered by different w
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@khalidhuseynov what is the benefit of having a new websocket call? will
rest api call be enough?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1160
Is it better to have the Date potentially hidden or the title hidden?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@Leemoonsoo updated code and screenshot with feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1160
Looks good. Can we display time as well as date in each revision?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1160
@corneadoug thanks for the help with rendering list, and i've fixed the
tests. CI is green and ready for review.
---
If your project is set up for it, you can reply to this email and have
18 matches
Mail list logo
