Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
Thanks @astroshim ! CI is green now, merging to master if there is no
further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
The reason of CI fails is..
```
Resolving deltas: 100% (13946/13946), completed with 385 local objects.
From https://github.com/apache/zeppelin
* branchrefs/pull/1193/
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
CI is still red :\ Could you please post here the reason?
Other than that, looks good to me, merging to master if there is no further
discussion
---
If your project is set up for it, you can
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
\cc @bzz Ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@bzz I rebased. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@astroshim great! Small suggestion above. And what is with CI here? May be
it's worth to `git rebase master` and force push?
---
If your project is set up for it, you can reply to this email and have
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@bzz I added log and tested. Thank you for taking care of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
Looks great to me, modulo the timeout logging issue noted about.
@astroshim plz ping when it's addressed and I'll be happy to merge it.
---
If your project is set up for it, you can reply to
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
\cc @bzz for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1193
please review this. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
10 matches
Mail list logo