[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1218 @cloverhearts Really great feature! I can't wait to build and run this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user raulgomis commented on the issue: https://github.com/apache/zeppelin/pull/1218 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1218 This PR is way too big to be reviewed properly. I'm not sure every settings are necessary (especially from the start). And I also have issues with the fact that every Theme from Ace is in

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 Thank you for feedback @corneadoug . I can possible divide to this pr. and I have a question. ``` I also have issues with the fact that every Theme from Ace is included.

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1218 @cloverhearts it would be nice to divide it in multiple PRs and commits. For the theme, I'm not against them wanting to change it, however in this case crowding the build by importing all th

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 I removed the feature to change the theme. It will also split into a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1218 I agree with @corneadoug that this is a big change to review. One more thing - @cloverhearts can you please add some tests for this feature? See `AuthenticationIT.java` for an example of I

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1218 @cloverhearts Don't hesitate to ping me when you start making the small PRs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 @bzz @corneadoug Okay, Thank you very much --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1218 Shall we close this one now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1218 @cloverhearts ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 @bzz i am sorry to late for response. The PR was divided. https://github.com/apache/zeppelin/pull/1256 and jira issue subtask https://issues.apache.org/jira/browse/ZEPPELIN-121

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1218 That looks great! Thank you @cloverhearts let's close this PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 @bzz Okay! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user hyonaldo commented on the issue: https://github.com/apache/zeppelin/pull/1218 How can I use this feature? Though I've installed latest build version, I could not find "Editor Configuration menu" anywhere. --- If your project is set up for it, you can reply to this ema

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 @hyonaldo Sorry, We can not support this feature on zeppelin. I do not care for this feature into master. It also differs from the current source in many ways. Re-implement