[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 I'm sorry for delay, @mwkang - my plate was full last week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 ping @bzz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 Thank you for your patience @mwkang ! Sorry for the late notice, but could you please take a look and make sure that code conforms the project styleguilde? Will merge to master asap, righ

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 @mwkang thank you for friendly ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz I think This PR have some trouble merging to master. Because When bzz leave comment, I also leave comment immediately. So bot did not recognize this PR. Could you mind if you check a

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 Thanks! In my experience, if in case of CI failure PR author posts the failure result from logs - that speeds us review a lot! CI fails now on Spark 1.6 Scala 2.10 and Scala 2.11 profiles with

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz Thanks for your review. I rebase on to master and force push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 This looks like an issue fixed in master 10h ago: ``` - should provide onclick method *** FAILED ***  The code passed to eventually never returned normally. Attempted 1

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 Ok, good to know, let me look into that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz No, It does not persists every time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 > If you re-trigger CI more (close&re-open this PR) - does the same issue persists every time? I'm not sure if it persists. I will re-tigger after fix the issue. --- If your project is set up

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 @mwkang thank you for prompt addressing reviews! If you re-trigger CI more (close&re-open this PR) - does the same issue persists every time? --- If your project is set up for it, you can re

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 I am not sure this error is related with this issue. ``` Failed tests: ZeppelinSparkClusterTest.zRunTest:204 expected: but was: ``` --- If your project is set up for it, you can

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @jongyoul Sorry, I missed it. I will check. I appreciate your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1248 Do you check the error of CI? ``` Failed tests: NoteTest.insertParagraphWithLastReplName:159 expected:<%spark > but was: NoteTest.addParagraphWithLastReplName:144 expecte

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz I changed StringUtils is static import. Can you check the code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz I'm worried about that `static import` confused. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 > @bzz ~~Thanks for comment, But could you explain more why it doesn't make sense?~~ Ah.. Your meaning is that org.apache.zeppelin.interpreter.InterpreterFactory#isBinded move to Note.java. Is it

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 I refactor method name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1248 tested. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1248 👍 for having a test! Looks good to me, modulo the issue raised above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @jongyoul Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled