[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-12 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1277 Shall we close this guy then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1277 @bzz giving some context 1. this is not about whole `NotebookRepo` api, it's related to only one method [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/j

[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-03 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1277 First of all - I appreciate you patience and attention to details and your code looks great. There are few design aspects of it I wanted to discuss with you here From the diff tab: > +116

[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1277 @bzz this is different approach to the problems you mentioned in #1254. Here i decouple Revision from RevisionId class and make the latter one generic so that developers can provide their o