Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I am not sure what is my next step. And this PR was created very long time
ago. So enviroment changed before. I think other contributor can resolve better
than me. So I closed this PR.
Thanks f
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@corneadoug
Thanks for you review. I checked them.
Before I fix it, I have several questions.
Do you mean do not change CTRL + ENTER function?
And Is this PR not useful for Zeppelin
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Just tested quickly, I will have to run more test to check the
behavior in general.
There is some refactoring needed, I left some comments.
Otherwise, a more global question
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@corneadoug Thanks for your comment. I rebased my branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang If you rebase again, the Error 2. Should be fixed.
Error 1. should just be a random one
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
There are 2 errors.
1. `ZeppelinSparkClusterTest.zRunTest:204 expected: but
was:` does not reproduce.
2.
`AuthenticationIT.testGroupPermission:179->AbstractZeppelinIT.pollingWait:96
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Can you rebase please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
`[ERROR] Failed to execute goal
com.github.eirslett:frontend-maven-plugin:0.0.25:npm (npm install) on project
zeppelin-web: Failed to run task: 'npm install --color=false' failed. (error
code 1) -
Github user resec commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang I am excited to see this enhancement implemented, great thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@resec That is more make sense. I will change when New cell added, Cursor
position is next line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user resec commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Just a minor suggestion, when presses and focus
moves to a new cell, is it better that the focused line is next to the [%xxx]?
so users can start typing new code right away without a . Per
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I remove `angular.element('#' + focusedParagraph +
'_paragraphColumn_main').scope().goToLineEnd()`, When paragraph runs.
Because each ace editor keeps cursor position.
So.. user enter `
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I am not sure. But I think it is persist error.
```
Failed tests:
ParallelSchedulerTest.testRun:63 expected: but was:
```
Anyway.. @Leemoonsoo I change code that it does n
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I am not sure it is related with this PR.
When I run it, it passed.
```
Failed tests:
ParallelSchedulerTest.testRun:63 expected: but was:
```
---
If your project is set up fo
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I handle that unnecessary persisted in note.json.
I find some problem.
While new paragraph is added in runParagraph, focus is not end of line.
It ignore space character.
But
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@Leemoonsoo Yes, I agree with you.
I will change that. Thanks for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1290
Thanks @mwkang for the contribution. Tested and it works well.
However, i'm not sure about passing informations like "isKeyEvent",
"moveFocusToNextParagraph", etc, through `paragraph.co
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1290
@mwkang Thanks for the improvement! Tested locally and it works well as
expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
Could you mind if I am going to resolve that consider running paragraph is
successful on new issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
20 matches
Mail list logo
