Github user vinayshukla commented on the issue:
https://github.com/apache/zeppelin/pull/1362
Thanks @vensant
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1362
@vensant Thank you! Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1362
Code changes done as per the review comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1362
+1 for @corneadoug, rest LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user vensant commented on the issue:
https://github.com/apache/zeppelin/pull/1362
Hi all,
I will change the tool tip names as suggested.
Thank you all
Regards,
Venkat
On 26 Aug 2016 7:57 am, "Lee moon soo" wrote:
> +1 for @cornead
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1362
+1 for @corneadoug 's comment. Shorter name is actually more clear and
easier to understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1362
Tested, LGTM
However maybe the tooltip names could be changed to something more simple:
* Multi Bar Chart -> Bar Chart
* Stacked Area Chart -> Area Chart
* Line With Focus Chart -
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1362
@vensant thank you for contributing improvement!
With GUI changes, in my experience, adding simple screenshots to the PR
itself (drag'n'drop to description) before\after usually helps to speed
