Github user karuppayya commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Very useful feature!!
let me know if i can help in taking this PR forward
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Actually it's a bit hard for me to help since I can't rebase
for you (Don't have the rights on your branch), but I can see that it is a
pretty messy conflict you got.
For
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug I have trouble with the rebase:( ... can you help a little bit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Yes, you will need to rebase first though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug merged your PR.
Do you think now it is the good time to merge this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug I have fixed the bug you mentioned. Testing was done and it
seems ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang I tested this PR and found one bug.
* Change a column that wouldn't order properly to Numerical type (balance
in bank table for example)
* Order that column in descending or
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug I just found that Handsontable has its intrinsic data type
detection/conversion which we can rely on for the type conversion and is thus
safer. More details at http://docs.handsont
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Thanks for the ping, I will look into that.
Any specific reason to drop #1371?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug can we get this reviewed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
I made several changes for this commit:
1. put the style from notebook.css to paragraph.css
2. do not make any assumption/auto-detection of the original type of the
data. Basically
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Let's try to rebase this one, and review it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@bzz I agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Let's merge #1371 first, and then it makes perfect sense to adjust this one
to match user expectations of sorting changes according to column type (so it
lets user override auto-detection).
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Added another PR #1371 that may have impact on this one.
i.e. if you guys think that one is reasonable then this one should be
adjusted so that when user changes the datatype of the column
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Well, consider it alone, yes it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Go it! It would be really nice to have such defaults for numbers, that make
them sort numerically.
As for letting user change it - it sounds good, am it looks like the main
use case for it is
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@bzz Actually I am currently look into that and I think it is possible
because numbers are automatically detected and that is why the commas are
inserted.
But I think even we could have th
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1363
So cool - this should solve sorting issue for numeric columns! Thank you
@Peilin-Yang!
One question - do you guys think it could be possible to detect numeric
columns automatically using some
Github user Peilin-Yang commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@corneadoug thanks for your advice!
I updated the contents of PR so that it includes the use cases of this
change.
Please let me know whether they make any sense.
---
If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Thanks for the contribution.
Small tip: Instead of hosting your screenshot, you can drop the image
directly in the input of the PR description and the image will be hosted by
g
21 matches
Mail list logo
