Github user WegDamit commented on the issue:
https://github.com/apache/zeppelin/pull/1369
Those changes are only for dependencies given in the interpreter
definition, right?
Using a %spark.dep section in a notebook seems to uses a
SparkDependencyContext which does not inherit from
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
OK I'll merge if no more remarks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Checked again and it works well! After removing the wrong
dependency, the error message doesn't show up anymore.
---
If your project is set up for it, you can reply to this email
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Yeah your screenshot is saying so. Let me test it again. Thanks
for your quick response!
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@AhyoungRyu
I followed your procedure but it works perfectly for me, see below
screenshot. Did you clean your browser cache when testing the new commit ?
Maybe there is some old JS co
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai So sorry for my late response ã
_ã
Tested again and checked
>when you navigate to different pages, the error popups are removed.
the above issue is gone! ð
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@AhyoungRyu @astroshim
Please tell me if it's ok so that I can merge. We need to merge this PR
before I can move on the refactoring task (of changing `synchronized` blocks by
appropri
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim @AhyoungRyu
Please see the final result, it should make you both happy :)
![fixed error
popups](https://cloud.githubusercontent.com/assets/1532977/19050426/d23f560e
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim @AhyoungRyu
The wrong counting on error popup is now fixed. Every time you
* reload the interpreter page
* update an interpreter setting
all the error
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@AhyoungRyu
> The ng-toast error message is still shown as @astroshim said in the above
comment. How about adding some timeout property to the message?
I knew that there is a
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Sorry for my late response and thanks for the kind reminder.
I tested again and checked the below issues I mentioned are gone :D
>(edit interpreter -> add `one:two:1.1.1` to t
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Could you take a look at the following screenshot?
After the `alluxio` and `angular` dependency error occurs, I just saved
`alluxio` interpreter setting several times but the `ang
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim
> the number seems doesn't match with count
What do you mean by this ? Which number did you expect to see ?
On the animated screencapture, the count started
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai I know that number means but as you can see the screenshot i
attached, the number seems doesn't match with count.
---
If your project is set up for it, you can reply to this email a
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim
The number you see in front of each error popup is normal, it comes from
the fact that now we set `combineDuplications = true` for **ngToast**. The
number corresponds to t
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Sorry to keep you waiting.
It works like a charm now but the error count number at the beginning of
message appears a little strange like following screen shot.
![st](https:
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@AhyoungRyu @astroshim Is the fix ok for you now ? The build is green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim @AhyoungRyu
Ok I've found the issue, it's my bad:
```javascript
for (var setting = 0; setting < $scope.interpreterSettings.length;
setting++) {
var
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim @AhyoungRyu it tooks me hours but I have found the root cause of
the issue and it's pretty ugly. Ready to hear ?
1) First issue is we **do not** set the InterpreterSetting `s
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
O I've found the issue, it's tricky.
I have added a non-existing dependency to the angular interpreter and I can
also see a spinning circle forever. With Web Dev Console, I can see
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
Let me investigate the root cause, it should be some Javascript subtle bug
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1369
I also checked the interpreter setting page like @astroshim did.
(edit interpreter -> add `one:two:1.1.1` to the dependency table -> save )
Two things are different with master br
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Could you check the infinitely downloading library problem(like
following screen shot)?
Strangely this problem happens all interpreter except spark. Is this
problem happen only
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim
> BTW how come only spark interpreter shows error message bar?
The error popup applies to all interpreters, try to add a fictive
dependency to `angular` or `shell`
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
Proxy repo tested and it works properly. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai BTW how come only spark interpreter shows `error message bar`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Good. I am going to check first commit(proxy) soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim Done, now the popup error is only displayed once even if you
update many other interpreters.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
Ok let me push a new commit with the `combineDuplications = true`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
Wow very quick response!!:
I think set `combineDuplications` true is better but I don't have much
talent in UI.:)
---
If your project is set up for it, you can reply to this email and hav
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim
It is explained above:
> The problem is that $route.reload(); in the success callback of
updateInterpreterSetting() will trigger init() then getInterpreterSettings(
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1369
About the second commits, Is it intended behavior that the error message
bar is stacked whenever save the other interpreter setting?
![image](https://cloud.githubusercontent.com/assets/
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@astroshim @minahlee Can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@jongyoul Sorry, it was a bad copy/paste between Github & JIRA, fixed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@doanduyhai Could you please specify the title of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user doanduyhai commented on the issue:
https://github.com/apache/zeppelin/pull/1369
@felixcheung
That's the main issue I'm facing now, how to **automate** test with
corporate firewall ... I'm going to ask someone to test the this PR at his
place (he has a corporate f
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1369
LGTM - how could we have automated tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
37 matches
Mail list logo