[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-10-01 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-29 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 CI is green LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-29 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 Reopening the pull request as the build failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-27 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 Reopening the pull request as the build failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-26 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 @corneadoug instead of validating the error in server side, I have just changed the code in the client side, that compares the input file size with the maximum limit of file size that is already s

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-25 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 @vensant it would be better to properly catch the error in the back-end and send it to the front --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-22 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 @r-kamath thanks for the inputs! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-22 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 @corneadoug once the file is uploaded, it tries to process the json but because the file exceeds the max limit it tries to close the websocket event. so I am trying to broadcast and catch the erro

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-21 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1430 @vensant I don't really get why the error is being triggered this way. We are talking about the file size, but we show the error when the Websocket connection is cut. One example is

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-16 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/1430 @vensant Nice update. Can you also make this limit on UI dynamic by reading the size configured in zeppelin-site.xml or zeppelin-env.sh. Look for`zeppelin.websocket.max.text.message.size` or `ZE

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-16 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 Closed and reopened the pull request in order to re-trigger the Travis CI build. Build failed due to test failures Again --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-16 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 Closed and reopened the pull request in order to re-trigger the Travis CI build. Build failed due to test failures Again --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1430: [ZEPPELIN-868] Notebook import fails when notebook is ...

2016-09-16 Thread vensant
Github user vensant commented on the issue: https://github.com/apache/zeppelin/pull/1430 Closed and reopened the pull request in order to re-trigger the Travis CI build. Build failed due to test failures --- If your project is set up for it, you can reply to this email and have your