[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-11-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1433 Merge if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-11-05 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1433 I did rebase and CI has passed. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-11-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1433 Now CI on master has fixed. @astroshim Could you rebase and see if it pass the test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-10-10 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1433 @Leemoonsoo ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-29 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1433 @astroshim CI failure is irrelevant @Leemoonsoo any feedback? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-29 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1433 re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-29 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1433 @Leemoonsoo CI has passed, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-21 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1433 @Leemoonsoo Thank you for pointing out the problem. Let me check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-21 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1433 @astroshim Currently only the last display system directive (%text, %html, ...) in the output is effective. Which is behavior of both InterpreterResult (static output) and InterpreterOutput (st

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-21 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1433 @corneadoug Thank you for your review. I just re-based. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-09-21 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1433 @astroshim Tested, nice fix. LGTM Can you rebase to have a green CI? @Leemoonsoo @jongyoul @felixcheung Can one of you guys take a quick look at the code? --- If your project is set up