[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom Sorry, I didn't get your reply, I create another PR for it #1861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1447 @purechoc Do you want to rebase it and continue work on it ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user purechoc commented on the issue: https://github.com/apache/zeppelin/pull/1447 LGTM. it's working nicely in my environment. (zeppelin 0.7 + livy 2.1) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1447 Sorry for late response. @spektom Could you add some additional message of session recreation to be displayed in frontend. Because if session is recreated, we may need to rerun all the paragraphs,

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom / @zjffdu @purechoc there is definitely an additional condition. Not sure if it's because the ConcurrentHashMaps are not being used correctly. But the exception doesn't get caught complet

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom just tested against my build by catching the exception and rethrowing.. It definitely solves the issue. } catch (LivyNoSessionException e) { throw e; } ca

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom I think what happens here is this code fires.. which has nothing to do with the fix here.. in LivySparkInterpreter: return livyHelper.interpretInput(line, interpreterCo

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user spektom commented on the issue: https://github.com/apache/zeppelin/pull/1447 @gss2002 are you using latest code from the branch? I can't find org.apache.zeppelin.livy.LivyHelper.interpretInput(LivyHelper.java:189) invocation at org.apache.zeppelin.livy.LivySparkInterprete

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom this fix is good. Did some extensive load testing with it this AM and it solves the session expiration issues. Thanks for the contribution --- If your project is set up for it, you can r

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user spektom commented on the issue: https://github.com/apache/zeppelin/pull/1447 @gss2002 you shouldn't be concerned about performance as this code only runs when command is executed. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1447 Also I have some concerns on using Exceptions to as goto's as there is definite performance issues that occur by using exceptions... http://javarevisited.blogspot.com/2013/03/0-exception-handling-

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user gss2002 commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom and @zjffdu is it possible to add a null check also. I've been doing some debugging over the past few days and certain situations can cause nulls to be returned and in theory if a null is

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user spektom commented on the issue: https://github.com/apache/zeppelin/pull/1447 Of course, it would be great. On Fri, Sep 23, 2016 at 06:28 Jeff Zhang wrote: > @spektom Thanks for the contribution, I am > working on a PR about inte

[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1447 @spektom Thanks for the contribution, I am working on a PR about integration test of livy interpreter, could you mind to wait for that PR and then add integration test to that ? --- If your proje