Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@bzz Thank you for your feedback. A MD documentation page is added to the
install section of Zeppelin documentation.
---
If your project is set up for it, you can reply to this email and have y
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal Thank you for contributing this.
I have several questions.
1. I think it needs `-it` option for running docker.
so The command to run zeppelin docker should be
`
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@astroshim Thank you for your reviews, Can you check the docker image again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal I checked point 1 and 3. Thank you fix properly.
Could you also fix to run the `R Tutorial` and `Python Tutorial` too?
I think all tutorial should be ran without error.
Wha
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal first of all thanks for initiative on this one, and few points
here:
* as i can see here Zeppelin images will be with hardcoded
`$ZEPPELIN_HOME/conf` folder and in order to
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal Awesome!
There are some places to inform the page's existence to the users.
Please check [documentation
guide#adding-new-pages](http://zeppelin.apache.org/contribution/docume
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal Ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@astroshim R and Python are installed and I think that the tutorials should
be run without errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@khalidhuseynov Thank you for your reviews. For the point # 1, I will work
on enhancing this in next pull request. And for 2 and 3, the docker image could
be run in the daemon mode and I added i
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal I got following error. Did i missed something?
```
$ docker pull mahmoudelgamal/zeppelin-release:0.6.1
0.6.1: Pulling from mahmoudelgamal/zeppelin-release
985c5f84712b:
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@astroshim I think it is just a message and the shell run normally. you can
run with this command `docker run --rm -it -p 8080:8080 -p 8081:8081
mahmoudelgamal/zeppelin-release:0.5.0 -c bash`. A
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal Could you tell me more detail about the issue on `from 0.6.0v to
0.6.2v` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal
I tried `zeppelin-release:0.6.0` image but it failed to run spark code in
`Zeppelin Tutorial`
```
$ docker ps
CONTAINER IDIMAGE
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Additionally, It would be better to
- run zeppelin immediately (using `zeppelin.sh` because we can run docker
as daemon mode)
- allow user to modify config important config files by pa
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal thank you for your great work and @astroshim @khalidhuseynov
@AhyoungRyu and @1ambda for prompt reviews!
I think @1ambda raised very good points, using `zeppelin.sh` will allow to
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal ping~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@astroshim sorry for the belated response. I worked on fixing the issue of
zeppelin version 0.6.It's solved by installing scala on the docker. This issue
only happens with the binary version d
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@1ambda Thank you for your review, The issue is solved, you can check
again. And Thank you for the suggested enhancement for zeppelin.sh script, I
think it will make the image better
---
If y
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal
What about having each **Dockerfile** for each released version? like this
[docker-library/mysql](https://github.com/docker-library/mysql/tree/10eb5eab8d3d793c49a701ed7a42e1e5d1
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@1ambda I already use automated build of dockerhub, when push any new
commit to my repo on github, the dockerhub builds the images recently. For
point 2, It's good point and I will take a look i
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@astroshim @bzz @1ambda
* Now I added a start-zeppelin.script to zeppelin-base image. It allow user
to modify some configs by passing env variables. Also the user can share the
logs and not
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal
First of all, I really appreciate this PR. This definitely helps users to
install and start zeppelin in one-command.
As you replied, you have automatically built docker
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal
Hi :) ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@1ambda It's good if we did that in apache zeppelin repo. but in this case
instead of using the created binary versions, we should build the source code
inside the docker.
Like that:
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Great job @mfelgamal !
The idea was to try to avoid building separate artefacts for Docker and use
official convenience binaries from Apache release.
Am I mimssing something, or wha
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Hi @bzz
So far, we have binary versions from 0.5.0 to 0.6.2, which help us building
docker image to each version instead of building the source code, but I mean
that if you want to mak
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal @bzz
I think we should dockerize binary zeppelin images first because more users
use binary versions.
---
If your project is set up for it, you can reply to this email and hav
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
> if we want to make dockerfile to the latest version from zeppelin which
haven't a binary version
This better be handled under a separate JIRA issue as this one is about
`[ZEPPELIN-1386] Doc
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
to recap - theare are two final things, that would be very nice to have in
this image:
- find a way to reduce base image size from ~500mb i.e by installing R
without `build-base make gcc g++`
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Now this issue is like more about building base image :) I will start
working on a new JIRA issue as @bzz mentioned about creating runnable zeppelin
images per version based on this. That would be
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@bzz I think that we need to install `build-base make gcc g++` to build
`knitr` package in R. And I wonder if we could remove them after building
`knitr`. Is this right?
---
If your project is
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal yes, exactly. Do you think this is possible? I wonder if the
image size would go down, if we remove those guys after getting `knitr`.
The goal would be to have a _minimal_ image that in
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Sort of. There's Conda for R:
https://www.continuum.io/content/preliminary-support-r-conda
But generally some R package are compiled on installation; knitr is a
relatively bigger one.
--
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@bzz I removed `curl build-base make gcc g++` for decreasing the image
size, now it's `301 MB`.
And `R` is run well.
---
If your project is set up for it, you can reply to this email and ha
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal that sounds awesome job, thank you very much.
Please let me test it tomorrow and get back to you here, but otherwise I
think it's ready to be merged!
---
If your project is set up
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal The reason, we can't run zeppelin binary on this docker image is
because of **dumb-init**. It prevent from running zeppelin well by just
installing **dumb-init**.
---
If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal could you please explain, why do you think one more script is
needed - `start-zeppelin.sh` and why `CMD["/bin/zeppelin.sh"]` can not be used
as entrypoint for the image?
@1ambda ha
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@bzz @1ambda the script `start-zeppelin.sh` isn't important, it just
enforce using port `8080` and zeppelin home dir `/usr/local/zeppelin`, we can
ignore it and use `zeppelin.sh`.
---
If your
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@bzz @1ambda are there further discussion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal
I agree with you opinion. We can directly use `usr/local/zeppelin` instead
of `start-zeppelin.sh`.
I'v just created PR for removing `start-zeppelin.sh` related files, codes,
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@1ambda that sounds awesome job, thank you very much. Now the PR is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Looks great to me, thank you @1ambda @mfelgamal
Let's wait for CI results and merge to master, if nothing comes up and
there is no further discussion!
---
If your project is set up for it,
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal Could you retrigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
First and second failing CI profile hit
[ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797)
Spark 1.5 had another troubles \w `DepInterpreterTest`
```
16/12/13 10
44 matches
Mail list logo
