Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1587
all green!
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
i think CI failure cause is not this PR.
some other reason in other testcase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1587
LGTM
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
thank to address.
update code completed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1587
shouldn't this be listed here:
https://github.com/apache/zeppelin/blob/master/conf/zeppelin-site.xml.template#L193
---
If your project is set up for it, you can reply to this email and have
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
@felixcheung @Leemoonsoo
please review this.
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1587
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
refector code based on #1612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
@zjffdu
thanks to comment.
i am wait #1612
#1612 is LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1587
I prefer to use `%livy.pyspark` & `$livy.pyspark3` instead of
`zeppelin.livy.kind`. Because if user change `zeppelin.livy.kind` some
paragraphs may not work again, this is very confusing. So
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
@zjffdu @felixcheung @Leemoonsoo
could you merge about this?
or need to fix something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1587
Ah thanks for pointing out. I will look into what Livy is doing shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1587
I see what you mean. Thanks for the explanation. Make sense.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
@Leemoonsoo .
thanks to comment.
you mean like this?
if user add property `zeppelin.livy.kind` = pyspark, "%livy.pyspark"
working on `python2`.
if user add property
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1587
Thanks for explain. but i'm little bit confused.
If you are creating `LivyPySpark3Interpreter` in addition to
`LivyPySparkInterpreter`, there will be no need to add property
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
@Leemoonsoo
thanks to review.
first. i try like that.
```
# add properties
{
"group": "livy",
"name": "pyspark3",
"className":
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1587
can't do that,
%livy.pyspark support python2 only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
17 matches
Mail list logo
