[GitHub] zeppelin issue #1590: [ZEPPELIN-1612] Fix NPE when initializing Notebook

2016-11-03 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1590 Got it! Thank you for kind explanation. CI failure looks not relevant for the change set. Looks great to me, merging to master if there is no further discussion. --- If your project

[GitHub] zeppelin issue #1590: [ZEPPELIN-1612] Fix NPE when initializing Notebook

2016-11-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1590 @bzz that function `loadAllNotes` is called only from constructor and when loading from constructor you're either in anonymous mode, or in shiro and loading all notes by anonymous (public).

[GitHub] zeppelin issue #1590: [ZEPPELIN-1612] Fix NPE when initializing Notebook

2016-11-03 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1590 Just wonder if that means that notes are always load as `anonymous` irregarding Zeppelin mode, because we do not have such permissions yet? Curious, as I would expect that we would load all no