Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1625
Thank you for the contribution!
LGTM and merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@Leemoonsoo CI is finally green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@Leemoonsoo fixed the test failure coming from rebase. all profiles pass
except the last selenium test failure with:
```
Results :
Tests in error:
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@khalidhuseynov Can you make CI green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
@Leemoonsoo thanks for review, addressed comments in
fc91b2f15725e91db1cbdf0439e8dd8779fc4f68. also rebased and resolved conflicts
since `docs/install/install.md` was recently changed.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1625
Thanks @khalidhuseynov for the contribution.
I think make permission public by default make sense, while it is current
behavior.
Could you add new configuration to
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1625
CI is green and ready for review. @Leemoonsoo feedback would be
appreciated, especially regarding the naming of say `zeppelin.notebook.public`
and `isPublic`. another way would be to name
