[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1637 @cloverhearts Thanks for the great contribution. LGTM and merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-28 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1637 @Leemoonsoo Sorry, I think I misunderstood your answer. All edits are complete. Thank you for your reply. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-28 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1637 Sorry, I think I misunderstood your answer. All edits are complete. Thank you for your reply. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-28 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1637 ci retry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1637 I still can see some unnecessary changes on the import code block in many files. Could you manage them unchanged? I have listed files in previous comment. --- If your project is set up

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-27 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1637 Okay, fixed all problem. always ci green i was change test case for zrun in angular object watch test. @Leemoonsoo Could you please review for this pr? --- If your project is set

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-26 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1637 One test case is experiencing a problem. I will solve this problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1637 Could you keep following files unchanged and resolve conflict with master? bigquery/src/main/java/org/apache/zeppelin/bigquery/BigQueryInterpreter.java

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

2016-11-22 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1637 All work is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and