[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1638 Great, CI is green now! Merging to master, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 Something is wrong. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1638 Awesome, 👍 for tests and a great commit\history structure that allows just to skip one and preserve all the work! --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 @bzz Removed styling commit. Let's see the CI result. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1638 Looks great to me, except for code style noted above. Thank you @1ambda for tests improvements, would be happy to merge as soon as the style issue addressed, if there is no further

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 I will rebase to clean useless commits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1638 Thank you for fixing bug. It's working as expected and adding test is also great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 ``` 05:33:43,422 INFO alluxio.logger.type:202 - Connecting to local worker @ testing-docker-d2b67f49-f525-4c23-a9ab-36aafddcf032/172.17.0.12:42241 05:33:43,422 ERROR

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 Currently all interpreters in each group shares same dependencies and options. So if we create 2 interpreters `postgres1` `postgres2` and set a dependency `postgres94.client.jar`

[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 Build profiles 2, 3, 4, 8 are nondeterministic :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this