[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2018-04-23 Thread BigDataDataAnalyst
Github user BigDataDataAnalyst commented on the issue: https://github.com/apache/zeppelin/pull/1694 @AhyoungRyu I am facing the same issue with Zeppelin. Here is the JIRA ticket link https://issues.apache.org/jira/browse/ZEPPELIN-3133 It would be great if

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2018-01-15 Thread RoxanaTapia
Github user RoxanaTapia commented on the issue: https://github.com/apache/zeppelin/pull/1694 @AhyoungRyu Can somebody have a look in the ticket? I was wondering if changing the role value to something else would help, until now all of them are * (e.g. admin = *, user= *) can I gran

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2018-01-10 Thread RoxanaTapia
Github user RoxanaTapia commented on the issue: https://github.com/apache/zeppelin/pull/1694 @AhyoungRyu Thanks for the quick response, here is the JIRA ticket link https://issues.apache.org/jira/browse/ZEPPELIN-3133 ---

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2018-01-09 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @RoxanaTapia Could you file a Jira issue here https://issues.apache.org/jira/projects/ZEPPELIN so that it can be tracked & handled separately ? Once a patch is merged, can't be opened again or

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2018-01-09 Thread RoxanaTapia
Github user RoxanaTapia commented on the issue: https://github.com/apache/zeppelin/pull/1694 Hi, I'm experiencing this issue but with shiro activated. I want the "Note Permissions" button to be activated only for authorized users (e.g. admins). Right now any user can access,

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2017-01-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1694 After this patch, if i turn off shiro and load any notebook (without click permission button) browser console print 403 forbidden,

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-26 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 Will merge this into master if there are no more comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-26 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @prabhjyotsingh Thanks! :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1694 Tested, works as expectation. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-25 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 Can someone review this one? 🎅🏼 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 CI is all green now! Ready to review. Here are some brief summaries what I did. Since from this PR `anonymous`(non authenticated) user can't set note permission, related test

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @prabhjyotsingh @cloverhearts @astroshim Sorry for my late response. I added checking anonymous user \w notebook rest api. So if anonymous users try to click lock icon / `GET` note

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @prabhjyotsingh @cloverhearts @astroshim Sorry for my late response. I added checking anonymous user by using websocket and updated PR description \w new UI screenshot image. Please take a

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-11 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1694 I agree with @prabhjyotsingh and @cloverhearts blocking to change the permission on a backend side too. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-11-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @prabhjyotsingh @cloverhearts Didn't think about that way. It makes sense. Thanks for your suggestion. Let me update then :) --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-11-29 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1694 It is a cool feature. I would like to say one thing. If you need to prevent configuration changes for anonymous users, you should not modify them only in the Web UI.

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-11-28 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1694 Haven't tried it yet, but IMO we should have a check at backned for the same (both API and websocket). --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-11-28 Thread prabhu-pictink
Github user prabhu-pictink commented on the issue: https://github.com/apache/zeppelin/pull/1694 Haven't tried it yet, but I think we should have a check at backned for the same (both API and websocket). --- If your project is set up for it, you can reply to this email and have your