[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Hi all, This PR looks like unbacked from the point of view design. I will close this issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-17 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Hi all, Let me know if anything needed to be changed from design to code style! Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-13 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1734 Guys, if I may, I would suggest keep the discussion in PR focused on the subject of the PR and move general topics of project's CI stability to the public dev@ mailing list and appropriate JIRA issues

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks @1ambda. Seems it much better! Let me test again. So true. Currently the CI test result makes us more confused and really hard to find what the problem is :( --- If your project is

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Totally agree with @zjffdu's opinion. [Here are unresolved flaky tests](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20flaky%20ORDER%20BY%20status%20ASC)

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1734 I also notice this failed test in travis. I think there're several jiras tracking the flaky test. The flaky test waste every developer's time. I think we should spend some time to fix them. What d

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 - Selenium tests passed by fixing https://github.com/apache/zeppelin/pull/1734/commits/c377cf8f255fa714d4b65061daf5239e86e8f641 - The profile 3 (scala 2.10, spark 1.6.3) failed but irrelevant wi

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-12 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks for detailed review @AhyoungRyu ### 1. Fixed Inputbox placeholder https://cloud.githubusercontent.com/assets/4968473/21129948/9338c5f4-c148-11e6-9f2d-73340957a1d0.png";>

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-08 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1734 @1ambda Great initiative for improving interpreter binding page UI! I also agree that current binding page is getting longer (thanks to the Zeppelin contributors :D) and getting hard to find. D

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-07 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1734 I like a green button for default interpreter feedback. especially, it seems to be a good choice for separating roles of interpreter. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 @Leemoonsoo I'v just fixed as commented above and updated GIF in the PR description --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 @1ambda that looks more make sense to me. fyi, a related PR https://github.com/apache/zeppelin/pull/423 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 @Leemoonsoo Thanks for your opinion! That's true there will be scrollbar anyway if we have many bindings. So What about adding scroll bar to the binding list? so that users can find

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks @1ambda for working on UX improvement. Personally, i'd prefer keep items in 1 column. Because it displays interpreter names (e.g. %spark, %pyspark, etc) at predictable location.