[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

2016-12-13 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1744 Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

2016-12-13 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1744 Thank you @Leemoonsoo and @bzz help to review. CI failure is not irrelevant to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

2016-12-12 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1744 Looks great to me, modulo minor issue above. Also, in my experience if CI failure reason is summarised and posted here by PR author - it makes merging/reviewing process much faster. --- If y

[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

2016-12-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1744 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the