Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Good job! @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Merge to master if no more comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1842
@AhyoungRyu Thanks for the review. Great to see High chart working nicely.
A lot more improvements on Helium menu will be required, like search page,
grouping packages by type, package
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1842
@Leemoonsoo Thanks! I just suggested to have some default message like
other pages (e.g. localhost:8080/#/interpreter -> there is "Manage interpreters
settings. You can create / edit / remove
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Thanks for the reviews and verifications!
@AhyoungRyu Addressed all the comments and fixed drag and drop problem.
When there is 0 or 1 visualization, reorder doesn't make any sense
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1842
When I enable zero or only one vizualization,
https://cloud.githubusercontent.com/assets/10060731/21853851/fd09d836-d85b-11e6-99ee-4320e309676c.png;>
I didn't no that there is
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1842
@Leemoonsoo Tested and it works well. It's really awesome! And ð for
having really well described docs. Let me create my own viz application as
explained in the documentation with real
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1842
And when I test npm online package for using bubble chart, It works very
well!
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1842
It's very cool feature!
Tested and It works very nice like below.
**[Test result]**
When I clicked `Enable` button for using `zeppelin_horizontalbar`
visualization package.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Let me review this PR. I wil comment again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Awesome! LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1842
Ci is green. I think this is ready. Please review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
12 matches
Mail list logo
