[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-02-01 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1940 From now, `SPELL` type pkg info fetched from [Helium registry](https://s3.amazonaws.com/helium-package/helium.json) is also shown in GUI :) https://cloud.githubusercontent.com/assets/100607

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-31 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 @1ambda Awesome new feature! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-29 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1940 finally, CI is green. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-29 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 Thanks addressing the comments. Tested and it works well as expected. Agree, 1) can be handled in separate issue while this PR already quite big. CI fails on RAT check profile

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-29 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1940 rebased to resolve conflict with master. @Leemoonsoo Thanks for detailed review! I updated code according to your comment. (1) **Couldn't make Spell as display system work:** Let's

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1940 Thanks @1ambda for contributing very interesting new feature. I've play around with it and have couple of feedbacks. ### Couldn't make Spell as display system work > The most imp