[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2006 Then I'll merge this to master if there is no further discussion! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2006 @AhyoungRyu sounds good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2006 @Leemoonsoo @1ambda I'm planning to make Helium packages sortable in [ZEPPELIN-2109](https://issues.apache.org/jira/browse/ZEPPELIN-2109). Can I handle the further improvement that you mentione

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2006 Okay, maybe then stick to black-grey, and see how it looks and improve later? Having label sounds good as well. maybe we can try put small npm logo. --- If your project is set up for it,

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2006 @Leemoonsoo Someday - what about black? - we might use labels such as `local` and `online` for helium packages. --- If your project is set up for it, you can reply to this email and h

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2006 It's nit. I think 'grey' can give impression that something is disabled or unavailable when it is compared to 'blue'. What do you think? Will there be any better way visually distinguish packag

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2006 I didn't noticed the latest change affects to the font color that I mentioned. Tested again and I like the idea to distinguish local pkg (-> grey) and online registered one(-> blue) with color.

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2006 Yeah looks good to me now! Before we merge this, can we handle the different font color as well? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2006 Thanks for reply! Then, use this logic to distinguish them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2006 @1ambda Sorry for my late comment. Also can't come up with better idea than `return pkg.artifact && !pkg.artifact.includes('@');` for now 🤔 --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2006 Or are there other ways to figure out local package? instead of `return pkg.artifact && !pkg.artifact.includes('@');` --- If your project is set up for it, you can reply to this email and have you

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2006 @AhyoungRyu Thanks for review. I'v changed the condition for checking local package. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2006: [ZEPPELIN-2099] Add NPM link for helium pkgs published...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2006 @1ambda Thanks for your effort! Tested and it works well as expected.