Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Okay, LGTM.
Merge master and branch-0.7 if no further discussion.
Regarding documentation, if LdapGroupRealm and LdapRealm are
superset/subset relation, we can mark one deprecated.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Rebased and green now. Thanks for your help.
Would you mind merging that into branch-0.7 as well?
Regarding docu:
The LDAP Realm section in the docu
[shiroauthentication.md](https://
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
@weand So far, we have a section for LdapRealm in
[shiroauthentication.md](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap).
> NotebookTest.test
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2062
@prabhjyotsingh There isn't any documentation for
org.apache.zeppelin.realm.LdapRealm yet.
@Leemoonsoo Any special reason why LdapRealm wasn't documented in 0.7.0
yet?
Can anyone
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Can you update the doc
(https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md#ldap)
as well, so user reading
http://zeppelin.apache.org/docs/0.7.0/security/sh
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2062
Thanks @weand for improvmenet.
Have you turn on "Build Pushes" in travis-ci settings?
