Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Thank you @felixcheung. Will merge this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@felixcheung Have handled your review comments. Let me know if I missed any.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@felixcheung ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@felixcheung have removed hard coded string "hive" as well.
CI fails for; not relavent for this change.
```
Tests in error:
ParagraphActionsIT.testClearOutputBu
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
> why is zeppelin.jdbc.auth.kerberos.proxy.enable removed?
My bad, while fixing the above issues, I thought this is redundant, but I
forgot about the case where KERBEROS is enabled
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
CI is green;
https://travis-ci.org/prabhjyotsingh/zeppelin/builds/225173700
https://travis-ci.org/prabhjyotsingh/zeppelin/builds/225214327
---
If your project is set up for it, yo
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@felixcheung Sure what you have recommended does make a lot of sense, have
implemented what you have suggested.
---
If your project is set up for it, you can reply to this email and have y
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2229
actually, I wasn't referring to the function name at all. instead of having
this fairly hive specific, how about a function like this to take the user name
property name and value
``
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Sure, got it, have renamed it to "appendProxyUserToURL".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Perhaps generalize this to something non-Hive specific? Like a property for
userStringToAppend? Add user to JDBC URL should be common place - seems like in
this case we just like a way to chan
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@felixcheung any specific change that you are looking for?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Yes, I thought of few options but this was bit con
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2229
From my earlier comment, I'm interested in others thought on having very
Hive specific logic in the generic JDBC interpreter?
https://github.com/apache/zeppelin/pull/2229/files#r110512
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Merging this to master and branch-0.7 if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@AhyoungRyu, @felixcheung ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2229
@AhyoungRyu @felixcheung thank you for the review, have made the suggested
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2229
Tested. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
17 matches
Mail list logo
