Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2235
CI build passed.
https://travis-ci.org/cfries/zeppelin/builds/224499519
Merge to master and branch-0.7 if no further comments.
---
If your project is set up for it, you can reply
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
@cfries looks like this PR is now including other changes? Could you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
great, I review again after rereading what you are saying and I think they
make sense and starting ZEPPELIN_CLASSPATH with CLASSPATH should make in
compatible
---
If your project is set up
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2235
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2235
Also: on OS X the zeppelin does not run if you export CLASSPATH. So I
assume no body could rely on this issue.
---
If your project is set up for it, you can reply to this email and have your
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2235
Hi Felix.
I am not sure if I got your point. The user can change CLASSPATH and
zeppelin.sh will use that. Also, the user can change
${ZEPPELIN_CLASSPATH_OVERRIDES} and
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
hmm, I can see your approach though I can also see changing CLASS_PATH
makes sense in some cases (for example, a custom library to be loaded).
Do you think there is way to accommodate
