[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2251 @tinkoff-dwh Since conflicts are about lint errors, you can simply rebase by 1. keeping your change and run `rebase --continue` 2. then, execute `eslint src --fix` in `zeppelin-web`

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-18 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 edit ![edit](https://cloud.githubusercontent.com/assets/25951039/25130228/e2a28060-245a-11e7-895a-d7c1571f885f.png) view

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-18 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 @zjffdu not compatible (conf/notebook.json), another format of 'properties' (object instead of string)

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2251 Is it compatible with previous interpreter setting without type ? Maybe use text by default if no type is specified. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-17 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 @1ambda widget is ok. About another widgets: angular-xeditable has no implementations for that (there are html5 inputs but old browsers not support html5) --- If your project is set up

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-17 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2251 One suggestion. What about calling them as 'widget' or something instead of 'type'? cause we might add actual type like 'number', 'string',... as @leemoonsu mentioned. --- If your project is set

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-17 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 add ![n_add](https://cloud.githubusercontent.com/assets/25951039/25084422/c9f6aafe-2375-11e7-8952-36aee06d4637.png) edit

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2251 probably wouldn't be a good idea to change from password to plaintext? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-15 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2251 Yes, probably better to make immutable. In the first stage there were no plans to add more although i can add boolean (checkbox) --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

2017-04-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2251 Thanks @tinkoff-dwh for useful feature! Tested this PR. In interpreter setting page, I can change type of property.