Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2265
This PR has been opened for last week.
LGTM and Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Tested and it looks great! +1 for this change
---
If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@AhyoungRyu I'v just updated code.
But Jenkins is not triggered.
- (Travis) https://travis-ci.org/1ambda/zeppelin/builds/224840876
---
If your project is set up for it, you
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
It seems that `unpkg.com` is broken. Before, i was able to download it (CI
as well)
```
$ headroom.js
git:(ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down) â pwd
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@1ambda Yeah right right I misapprehended actually. It was my bad.
Btw I wanted to test this locally but failed when I run `yarn install` and
got this below 404 error.
```
[{
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@AhyoungRyu you can get navbar again by scrolling up few pixels. it's not
necessary to go to the top.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Cool!
Then to reach to the menu, some users who have lots of paragraphs have to
spend much time to scroll up. Then how about sticky "go to top" like button at
bottom-right side instead? I
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Tested and it works well!
Although i really really like this improvement because it allow utilize
small screen more efficiently, i'd like to open this PR for next few more days
for
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@Leemoonsoo Please help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@Leemoonsoo Please help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
10 matches
Mail list logo
